Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-725]: Remove tenant service ingress #552

Merged
merged 8 commits into from
Apr 5, 2023
Merged

[feature-725]: Remove tenant service ingress #552

merged 8 commits into from
Apr 5, 2023

Conversation

atye
Copy link
Contributor

@atye atye commented Mar 30, 2023

Description

Updates to remove the tenant-service endpoint and for karavictl tenant commands to send requests to the proxy-server.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#725

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

rsedlock1958
rsedlock1958 previously approved these changes Mar 30, 2023
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No edits required

alikdell
alikdell previously approved these changes Mar 31, 2023
View reviewed changes
@atye atye dismissed stale reviews from alikdell and rsedlock1958 via 19bb2e4 March 31, 2023 14:41
sharmilarama
sharmilarama reviewed Apr 3, 2023
View reviewed changes
content/docs/authorization/cli.md Outdated Show resolved Hide resolved
content/docs/authorization/cli.md Outdated Show resolved Hide resolved
content/docs/deployment/csmoperator/modules/authorization.md Outdated Show resolved Hide resolved
@shanmydell shanmydell merged commit 3a28aa0 into release-1.7.0 Apr 5, 2023
@shanmydell shanmydell deleted the feature-725-remove-tenant-service-ingress branch April 5, 2023 06:49
rajkumar-palani pushed a commit that referenced this pull request May 22, 2023
@atye @rajkumar-palani
[feature-725]: Remove tenant service ingress (#552)
6bd1da0
rajkumar-palani pushed a commit that referenced this pull request May 23, 2023
@atye @rajkumar-palani
[feature-725]: Remove tenant service ingress (#552)
9196e09
rajkumar-palani pushed a commit that referenced this pull request May 23, 2023
@atye @rajkumar-palani
[feature-725]: Remove tenant service ingress (#552)
a54013f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaiasA1 IsaiasA1 IsaiasA1 left review comments

@sharmilarama sharmilarama sharmilarama approved these changes

@shanmydell shanmydell shanmydell approved these changes

@alikdell alikdell alikdell left review comments

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro left review comments

@rsedlock1958 rsedlock1958 rsedlock1958 left review comments

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@gallacher gallacher Awaiting requested review from gallacher

@mgandharva mgandharva Awaiting requested review from mgandharva

@mjsdell mjsdell Awaiting requested review from mjsdell

@prablr79 prablr79 Awaiting requested review from prablr79

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@atye @alikdell @shaynafinocchiaro @sharmilarama @rsedlock1958 @shanmydell @IsaiasA1