Ingress removal storage service #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaiasA1
requested review from
bharathsreekanth,
Deepak-Ghivari,
gallacher,
mgandharva,
mjsdell,
prablr79,
rajendraindukuri,
rajkumar-palani,
rsedlock1958 and
shanmydell
as code owners
sharmilarama
previously approved these changes
Apr 6, 2023
alikdell
previously approved these changes
Apr 6, 2023
content/docs/authorization/cli.md
Outdated
| @@ -615,7 +617,9 @@ karavictl storage [flags] | |||
| ##### Options | |||
|
|
|||
| ``` | |||
| -h, --help help for storage | |||
| --addr string address of the csm-authorization storage service | |||
There was a problem hiding this comment.
Now that addr is the same for tenant and storage service, lets keep the description consistent to be Address of the server (default "localhost")
content/docs/authorization/cli.md
Outdated
| -h, --help help for storage | ||
| --addr string address of the csm-authorization storage service | ||
| -h, --help help for storage | ||
| --insecure insecure skip verify |
There was a problem hiding this comment.
If this insecure flag serves the same purpose as the insecure flag for storage, lets keep the description consistent - Skip certificate validation
…dell/csm-docs into Ingress-removal-storage-service
IsaiasA1
dismissed stale reviews from alikdell, sharmilarama, and rajkumar-palani
via
a22bf81
IsaiasA1
requested review from
rajkumar-palani,
alikdell,
shaynafinocchiaro and
sharmilarama
shaynafinocchiaro
approved these changes
Apr 6, 2023
rajkumar-palani
pushed a commit
that referenced
this pull request
May 22, 2023
* tenant service updates * fix directory in operator auth deployment * updating docs to latest changes on storage servicce * consistant descriptions --------- Co-authored-by: atye <tyeaaron@gmail.com>
rajkumar-palani
pushed a commit
that referenced
this pull request
May 23, 2023
* tenant service updates * fix directory in operator auth deployment * updating docs to latest changes on storage servicce * consistant descriptions --------- Co-authored-by: atye <tyeaaron@gmail.com>
rajkumar-palani
pushed a commit
that referenced
this pull request
May 23, 2023
* tenant service updates * fix directory in operator auth deployment * updating docs to latest changes on storage servicce * consistant descriptions --------- Co-authored-by: atye <tyeaaron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated documentation on the Karavictl, and Authorization pages to cover the changes made by this PR: (dell/karavi-authorization#224) which covers storage-service being removed from the Ingress.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: