Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csm installation wizard node selector issue #681

Merged

Conversation

niranjan-n1
Copy link
Contributor

@niranjan-n1 niranjan-n1 commented Jun 16, 2023

Description

This PR adds the option to enable taints and install pods on control-plane through Installation Wizard

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#698

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Tests:

  1. Generated values.yaml from Installation Wizard with the option of installing controller and node pods on Control Plane
  2. Generated values.yaml from Installation Wizard with the option of installing only the controller pods on Control Plane
  3. Generated values.yaml from Installation Wizard with the option of installing only the node pods Control Plane
  4. Validated the scenarios on CSI-Powerstore, CSI-Unity and CSI-Powerflex drivers

Screenshots attached for Unity and Powerstore drivers:

fix-2
fix-3
fix-4
unity-fix-5

@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Test Results

55 tests   55 ✔️  1s ⏱️
  3 suites    0 💤
  1 files      0

Results for commit 35f7277.

♻️ This comment has been updated with latest results.

samihan-dell
samihan-dell previously approved these changes Jun 16, 2023
rsedlock1958
rsedlock1958 previously approved these changes Jun 16, 2023
prablr79
prablr79 previously approved these changes Jun 19, 2023
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niranjan-n1 - please provide the GitHub issue linked to this PR. Please also provide a listing of the tests that have been executed.

@niranjan-n1 niranjan-n1 merged commit b52ab9e into release-1.7.0 Jun 20, 2023
3 checks passed
@niranjan-n1 niranjan-n1 deleted the csm-installation-wizard-node-selector-issue branch June 20, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants