Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PowerFlex 4.5 support #842

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Added PowerFlex 4.5 support #842

merged 9 commits into from
Sep 25, 2023

Conversation

gallacher
Copy link
Contributor

@gallacher gallacher commented Sep 25, 2023 •
edited
Loading

Description

Added CSI Driver for PowerFlex support for PowerFlex 4.5

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions
Copy link

github-actions bot commented Sep 25, 2023 •
edited
Loading

Test Results

76 tests  ±0   76 ✔️ ±0   1s ⏱️ -1s
  3 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c1de59f. ± Comparison against base commit 4a1c599.

♻️ This comment has been updated with latest results.

gallacher
gallacher commented Sep 25, 2023
View reviewed changes
content/docs/csidriver/_index.md Outdated
{{</table>}}

>Note: To connect to a PowerFlex 4.5 array, SDC image will need to be changed to dellemc/sdc:4.5. Review PowerFlex install documentation for more details.
Copy link
Contributor Author

@gallacher gallacher Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more details about where to make that change? Also provide a link to the CSI driver for PowerFlex install documentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added details and links for both install methods

mjsdell
mjsdell approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@mjsdell mjsdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gallacher gallacher merged commit 7231f9b into main Sep 25, 2023
@gallacher gallacher deleted the update-powerflex-support branch September 25, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobGros JacobGros JacobGros left review comments

@mjsdell mjsdell mjsdell approved these changes

@AronAtDell AronAtDell AronAtDell approved these changes

@hoppea2 hoppea2 hoppea2 approved these changes

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@chimanjain chimanjain Awaiting requested review from chimanjain

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@mgandharva mgandharva Awaiting requested review from mgandharva

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell

@sharont58 sharont58 Awaiting requested review from sharont58

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gallacher @JacobGros @hoppea2 @AronAtDell @mjsdell