Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gopowermax version #33

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update gopowermax version #33

merged 1 commit into from
Dec 6, 2023

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Dec 6, 2023

Description

Update gopowermax version to v2.5.1

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1012

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@csmbot
Copy link
Collaborator

csmbot commented Dec 6, 2023

Can one of the admins verify this patch?

shefali-malhotra
shefali-malhotra approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shefali-malhotra
shefali-malhotra reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e pass

@nitesh3108
Copy link
Collaborator

skip e2e

@nitesh3108
Copy link
Collaborator

e2e pass

@donatwork
Copy link
Contributor

e2e pass

@chimanjain chimanjain merged commit 847285b into main Dec 6, 2023
7 checks passed
@chimanjain chimanjain deleted the update-gopowermax branch December 6, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@chimanjain chimanjain chimanjain approved these changes

@donatwork donatwork donatwork approved these changes

@forrestxia forrestxia Awaiting requested review from forrestxia

@YianZong YianZong Awaiting requested review from YianZong

@baoy1 baoy1 Awaiting requested review from baoy1

@taohe1012 taohe1012 Awaiting requested review from taohe1012

@P-Cao P-Cao Awaiting requested review from P-Cao

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@panigs7 @csmbot @nitesh3108 @donatwork @chimanjain @shefali-malhotra