-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable backup Unisphere #8
Conversation
09c5dd3
to
a72f64b
Compare
run e2e test |
@@ -111,6 +115,12 @@ func Run(ctx context.Context, config *Config, exporter otlexporters.Otlexporter, | |||
performanceTickInterval := config.PerformanceTickInterval | |||
performanceTicker := time.NewTicker(performanceTickInterval) | |||
|
|||
livenessProbeTickInterval := config.LivenessProbeTickInterval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no place to set config.LivenessProbeTickInterval
, so why livenessProbeTickInterval := config.LivenessProbeTickInterval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for test case purpose.
Previously backup U4P URL is only used when building connection, and backup U4P connection will not be saved if primary URL is working. Considering primary URL will stop working somehow, we cannot get valid connection. So we need to save backup connection if primary U4P stop working.
a72f64b
to
09ec8cb
Compare
run e2e test |
2 similar comments
run e2e test |
run e2e test |
Description
Previously backup U4P URL is only used when building connection, and backup U4P connection will not be saved if primary URL is working. Considering primary URL will stop working somehow, we cannot get valid connection.
So we need to save backup connection if primary U4P stop working.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources