Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable backup Unisphere #8

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

baoy1
Copy link
Collaborator

@baoy1 baoy1 commented Feb 13, 2023

Description

Previously backup U4P URL is only used when building connection, and backup U4P connection will not be saved if primary URL is working. Considering primary URL will stop working somehow, we cannot get valid connection.
So we need to save backup connection if primary U4P stop working.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#586

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make check test
➜  csm-metrics-powermax git:(feature-586-enable_backup_u4p_probe) make check test
./scripts/check.sh ./cmd/... ./opentelemetry/... ./internal/...
=== Checking format...
=== Finished
=== Vetting...
=== Finished
=== Linting...
=== Finished
=== Running gosec...
=== Finished
go test -count=1 -cover -race -timeout 30s -short `go list ./... | grep -v mock`
?       github.com/dell/csm-metrics-powermax/cmd/metrics-powermax       [no test files]
ok      github.com/dell/csm-metrics-powermax/internal/common    0.401s  coverage: 92.3% of statements
ok      github.com/dell/csm-metrics-powermax/internal/entrypoint        1.528s  coverage: 93.4% of statements
ok      github.com/dell/csm-metrics-powermax/internal/k8s       0.129s  coverage: 94.3% of statements
?       github.com/dell/csm-metrics-powermax/internal/k8sutils  [no test files]
?       github.com/dell/csm-metrics-powermax/internal/reverseproxy/common       [no test files]
ok      github.com/dell/csm-metrics-powermax/internal/reverseproxy/config       0.324s  coverage: 91.2% of statements
?       github.com/dell/csm-metrics-powermax/internal/reverseproxy/utils        [no test files]
ok      github.com/dell/csm-metrics-powermax/internal/service   0.089s  coverage: 100.0% of statements
ok      github.com/dell/csm-metrics-powermax/internal/service/metric    0.139s  coverage: 94.8% of statements
?       github.com/dell/csm-metrics-powermax/internal/service/types     [no test files]
?       github.com/dell/csm-metrics-powermax/opentelemetry/exporters    [no test files]
ok      github.com/dell/csm-metrics-powermax/utils      0.036s  coverage: 100.0% of statements

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

Base automatically changed from feature-586-obs-powermax-performance to main February 13, 2023 13:24
@baoy1 baoy1 force-pushed the feature-586-enable_backup_u4p_probe branch from 09c5dd3 to a72f64b Compare February 13, 2023 13:35
@baoy1
Copy link
Collaborator Author

baoy1 commented Feb 13, 2023

run e2e test

@baoy1 baoy1 marked this pull request as ready for review February 13, 2023 14:09
@@ -111,6 +115,12 @@ func Run(ctx context.Context, config *Config, exporter otlexporters.Otlexporter,
performanceTickInterval := config.PerformanceTickInterval
performanceTicker := time.NewTicker(performanceTickInterval)

livenessProbeTickInterval := config.LivenessProbeTickInterval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no place to set config.LivenessProbeTickInterval, so why livenessProbeTickInterval := config.LivenessProbeTickInterval

Copy link
Collaborator Author

@baoy1 baoy1 Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for test case purpose.

internal/common/common.go Show resolved Hide resolved
taohe1012
taohe1012 previously approved these changes Feb 14, 2023
Previously backup U4P URL is only used when building connection,
and backup U4P connection will not be saved if primary URL is working.
Considering primary URL will stop working somehow, we cannot get valid
connection.
So we need to save backup connection if primary U4P stop working.
@baoy1
Copy link
Collaborator Author

baoy1 commented Feb 15, 2023

run e2e test

2 similar comments
@baoy1
Copy link
Collaborator Author

baoy1 commented Feb 15, 2023

run e2e test

@baoy1
Copy link
Collaborator Author

baoy1 commented Feb 15, 2023

run e2e test

@baoy1 baoy1 merged commit 8f53598 into main Feb 17, 2023
@baoy1 baoy1 deleted the feature-586-enable_backup_u4p_probe branch March 8, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants