Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mount Credentials #95

Merged

Conversation

falfaroc
Copy link
Contributor

@falfaroc falfaroc commented Feb 4, 2025

Description

With the recent changes to support the secret and config map, the processing within PowerMax Observability needed adjustment. This add the support for both approaches.

Also, we've stripped out duplication of a reverseproxy within here and leveraged the ability to import the Powermax Reverseproxy as a module to be used for parsing the secret/configmap.

The Code Coverage is 90% except for the mock packages.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1614

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Manually deployed and tested using both approaches, ensuring that the observability pods are up and running as expected.

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

image

image

  • Ran the Cert-CSI VolumeIO test suite and verified parallelly on the Grafana dashboard for the Performance and the Storage Metrics
    image
    image
    image

@csmbot
Copy link
Collaborator

csmbot commented Feb 4, 2025

Can one of the admins verify this patch?

@harshitap26 harshitap26 requested a review from panigs7 as a code owner February 7, 2025 10:45
@harshitap26 harshitap26 requested review from tdawe, xuluna, lukeatdell and fernandozambone and removed request for fernandozambone February 7, 2025 10:46
@harshitap26 harshitap26 changed the base branch from main to usr/spark/mount-credentials February 10, 2025 13:06
@harshitap26 harshitap26 merged commit 692461f into usr/spark/mount-credentials Feb 11, 2025
8 of 9 checks passed
@harshitap26 harshitap26 deleted the usr/harshitap26/mount-credentials branch February 11, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants