Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go library #39

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Update go library #39

merged 1 commit into from
Dec 5, 2023

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Dec 4, 2023

Description

Update go client in go.mod

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1012

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@csmbot
Copy link
Collaborator

csmbot commented Dec 4, 2023

Can one of the admins verify this patch?

@donatwork
Copy link
Contributor

skip e2e test
e2e pass

Skipping e2e in pipeline dues to pipeline state. Please make sure longevity is run prior to release.

@donatwork
Copy link
Contributor

e2e pass

@chimanjain chimanjain merged commit 853ba72 into main Dec 5, 2023
8 checks passed
@chimanjain chimanjain deleted the update-golibrary branch December 5, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimanjain chimanjain chimanjain approved these changes

@gallacher gallacher gallacher approved these changes

@harshaatdell harshaatdell harshaatdell approved these changes

@donatwork donatwork donatwork approved these changes

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@panigs7 @csmbot @donatwork @harshaatdell @gallacher @chimanjain