Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade k8s.io modules to 0.31.0 #52

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Upgrade k8s.io modules to 0.31.0 #52

merged 2 commits into from
Sep 3, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Aug 29, 2024 •
edited
Loading

Description

Upgrade k8s.io modules to 0.31.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1431

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test
  • E2E test

@csmbot
Copy link
Collaborator

csmbot commented Aug 29, 2024

Can one of the admins verify this patch?

@chimanjain chimanjain marked this pull request as ready for review September 2, 2024 16:15
donatwork
donatwork reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete the checklist as best as you can.

@chimanjain chimanjain merged commit a8e4ff2 into main Sep 3, 2024
7 checks passed
@chimanjain chimanjain deleted the update-k8s-module branch September 3, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork left review comments

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@taohe1012 taohe1012 Awaiting requested review from taohe1012

@P-Cao P-Cao Awaiting requested review from P-Cao

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chimanjain @csmbot @donatwork @rajendraindukuri @shefali-malhotra