Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp all otel references and implementations #108

Merged
merged 23 commits into from
Dec 24, 2024
Merged

Revamp all otel references and implementations #108

merged 23 commits into from
Dec 24, 2024

Conversation

nitesh3108
Copy link
Contributor

@nitesh3108 nitesh3108 commented Dec 24, 2024

Description

This PR is all about revamp with all mandatory packages like -

  • otel
  • metrics instruments
  • viper
  • k8s.io/api, k8s/client-go
  • gopkg.in/yaml.v3
  • While updating these packages removed deprecated ones and implemented as per the latest spec.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT's ran successfully

Screenshot 2024-12-24 142406

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

Grafana dashboards when I/O is in progress.

image

@csmbot
Copy link
Collaborator

csmbot commented Dec 24, 2024

Can one of the admins verify this patch?

Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitesh3108 nitesh3108 merged commit 007a670 into main Dec 24, 2024
8 checks passed
@nitesh3108 nitesh3108 deleted the revamp-otel branch December 24, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants