Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace docker build with podman build #82

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Replace docker build with podman build #82

merged 1 commit into from
Sep 19, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Sep 19, 2024 •
edited
Loading

Description

Replace docker build with podman build and fix gosec issue.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built metrics image successfully and ran basic sanity test

@csmbot
Copy link
Collaborator

csmbot commented Sep 19, 2024

Can one of the admins verify this patch?

@chimanjain chimanjain marked this pull request as ready for review September 19, 2024 07:19
@chimanjain chimanjain self-assigned this Sep 19, 2024
donatwork
donatwork approved these changes Sep 19, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@chimanjain chimanjain merged commit 9357c68 into main Sep 19, 2024
7 checks passed
@chimanjain chimanjain deleted the use-podman branch September 19, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@donatwork donatwork donatwork approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees

@chimanjain chimanjain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chimanjain @csmbot @donatwork @rajendraindukuri @nitesh3108