Skip to content

Commit

Permalink
fixed review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rishabhatdell committed Dec 19, 2024
1 parent b3ada74 commit 0ce34ae
Show file tree
Hide file tree
Showing 84 changed files with 92 additions and 92 deletions.
2 changes: 1 addition & 1 deletion config/samples/storage_v1_csm_powerflex.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
# 'k8s' represents a string prepended to each volume created by the CSI driver
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner:v5.1.0
args: ["--volume-name-prefix=k8s"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher:v4.7.0
- name: registrar
Expand Down
4 changes: 2 additions & 2 deletions config/samples/storage_v1_csm_powermax.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "debug"
- name: "CSI_LOG_LEVEL"
value: "debug"
value: "info"
# CSI driver log format
# Allowed values: "TEXT" or "JSON"
# Default value: "TEXT"
Expand Down Expand Up @@ -201,7 +201,7 @@ spec:
# 'pmax' represents a string prepended to each volume created by the CSI driver
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner:v5.1.0
args: ["--volume-name-prefix=pmax"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher:v4.7.0
- name: registrar
Expand Down
4 changes: 2 additions & 2 deletions config/samples/storage_v1_csm_powerscale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "debug"
- name: "CSI_LOG_LEVEL"
value: "debug"
value: "info"
controller:
envs:
# X_CSI_ISI_QUOTA_ENABLED: Indicates whether the provisioner should attempt to set (later unset) quota
Expand Down Expand Up @@ -233,7 +233,7 @@ spec:
sideCars:
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner:v5.1.0
args: ["--volume-name-prefix=csipscale"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher:v4.7.0
- name: registrar
Expand Down
2 changes: 1 addition & 1 deletion config/samples/storage_v1_csm_powerstore.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
- name: KUBELET_CONFIG_DIR
value: /var/lib/kubelet
- name: CSI_LOG_LEVEL
value: debug
value: info
sideCars:
# 'csivol' represents a string prepended to each volume created by the CSI driver
- name: provisioner
Expand Down
2 changes: 1 addition & 1 deletion config/samples/storage_v1_csm_unity.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "info"
- name: CSI_LOG_LEVEL
value: debug
value: info
# CSI driver log format
# Allowed values: "TEXT" or "JSON"
# Default value: "TEXT"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ spec:
args:
- "--csi-address=$(ADDRESS)"
- "--feature-gates=Topology=true"
- "--volume-name-prefix=k8s"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--leader-election=true"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "TEXT"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ spec:
args:
- "--csi-address=$(ADDRESS)"
- "--feature-gates=Topology=true"
- "--volume-name-prefix=k8s"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--leader-election=true"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "TEXT"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ spec:
args:
- "--csi-address=$(ADDRESS)"
- "--feature-gates=Topology=true"
- "--volume-name-prefix=k8s"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--leader-election=true"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "TEXT"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ spec:
imagePullPolicy: IfNotPresent
args:
- "--csi-address=$(ADDRESS)"
- "--volume-name-prefix=pmax"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--worker-threads=6"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ spec:
imagePullPolicy: IfNotPresent
args:
- "--csi-address=$(ADDRESS)"
- "--volume-name-prefix=pmax"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--worker-threads=6"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ spec:
imagePullPolicy: IfNotPresent
args:
- "--csi-address=$(ADDRESS)"
- "--volume-name-prefix=pmax"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--worker-threads=6"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ spec:
imagePullPolicy: IfNotPresent
args:
- "--csi-address=$(ADDRESS)"
- "--volume-name-prefix=k8s"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--worker-threads=5"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "TEXT"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ spec:
imagePullPolicy: IfNotPresent
args:
- "--csi-address=$(ADDRESS)"
- "--volume-name-prefix=k8s"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--worker-threads=5"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "TEXT"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ spec:
imagePullPolicy: IfNotPresent
args:
- "--csi-address=$(ADDRESS)"
- "--volume-name-prefix=k8s"
- "--volume-name-prefix=csivol"
- "--volume-name-uuid-length=10"
- "--worker-threads=5"
- "--timeout=120s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "TEXT"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "TEXT"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "JSON"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "JSON"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "JSON"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "JSON"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ metadata:
namespace: <DriverDefaultReleaseNamespace>
data:
driver-config-params.yaml: |-
CSI_LOG_LEVEL: "debug"
CSI_LOG_LEVEL: "info"
CSI_LOG_FORMAT: "JSON"
PODMON_CONTROLLER_LOG_LEVEL: "debug"
PODMON_CONTROLLER_LOG_FORMAT: "JSON"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
sideCars:
# 'k8s' represents a string prepended to each volume created by the CSI driver
- name: provisioner
args: ["--volume-name-prefix=k8s"]
args: ["--volume-name-prefix=csivol"]
# sdc-monitor is disabled by default, due to high CPU usage
- name: sdc-monitor
enabled: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
sideCars:
# 'k8s' represents a string prepended to each volume created by the CSI driver
- name: provisioner
args: ["--volume-name-prefix=k8s"]
args: ["--volume-name-prefix=csivol"]
# sdc-monitor is disabled by default, due to high CPU usage
- name: sdc-monitor
enabled: false
Expand Down
2 changes: 1 addition & 1 deletion samples/ocp/1.6.0/storage_csm_powerflex_v2110.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
# 'k8s' represents a string prepended to each volume created by the CSI driver
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner@sha256:405a14e1aa702f7ea133cea459e8395fe40a6125c088c55569e696d48e1bd385
args: ["--volume-name-prefix=k8s"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher@sha256:b4d611100ece2f9bc980d1cb19c2285b8868da261e3b1ee8f45448ab5512ab94
- name: registrar
Expand Down
4 changes: 2 additions & 2 deletions samples/ocp/1.6.0/storage_csm_powermax_v2110.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "debug"
- name: "CSI_LOG_LEVEL"
value: "debug"
value: "info"
# CSI driver log format
# Allowed values: "TEXT" or "JSON"
# Default value: "TEXT"
Expand Down Expand Up @@ -221,7 +221,7 @@ spec:
# 'pmax' represents a string prepended to each volume created by the CSI driver
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner@sha256:405a14e1aa702f7ea133cea459e8395fe40a6125c088c55569e696d48e1bd385
args: ["--volume-name-prefix=pmax"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher@sha256:b4d611100ece2f9bc980d1cb19c2285b8868da261e3b1ee8f45448ab5512ab94
- name: registrar
Expand Down
4 changes: 2 additions & 2 deletions samples/ocp/1.6.0/storage_csm_powerscale_v2110.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "debug"
- name: "CSI_LOG_LEVEL"
value: "debug"
value: "info"
controller:
envs:
# X_CSI_ISI_QUOTA_ENABLED: Indicates whether the provisioner should attempt to set (later unset) quota
Expand Down Expand Up @@ -226,7 +226,7 @@ spec:
sideCars:
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner@sha256:405a14e1aa702f7ea133cea459e8395fe40a6125c088c55569e696d48e1bd385
args: ["--volume-name-prefix=csipscale"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher@sha256:b4d611100ece2f9bc980d1cb19c2285b8868da261e3b1ee8f45448ab5512ab94
- name: registrar
Expand Down
2 changes: 1 addition & 1 deletion samples/ocp/1.6.0/storage_csm_powerstore_v2110.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
- name: KUBELET_CONFIG_DIR
value: /var/lib/kubelet
- name: CSI_LOG_LEVEL
value: debug
value: info
sideCars:
# 'csivol' represents a string prepended to each volume created by the CSI driver
- name: provisioner
Expand Down
2 changes: 1 addition & 1 deletion samples/ocp/1.6.0/storage_csm_unity_v2110.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "info"
- name: CSI_LOG_LEVEL
value: debug
value: info
# CSI driver log format
# Allowed values: "TEXT" or "JSON"
# Default value: "TEXT"
Expand Down
2 changes: 1 addition & 1 deletion samples/ocp/1.6.1/storage_csm_powerflex_v2110.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
# 'k8s' represents a string prepended to each volume created by the CSI driver
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner@sha256:405a14e1aa702f7ea133cea459e8395fe40a6125c088c55569e696d48e1bd385
args: ["--volume-name-prefix=k8s"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher@sha256:b4d611100ece2f9bc980d1cb19c2285b8868da261e3b1ee8f45448ab5512ab94
- name: registrar
Expand Down
4 changes: 2 additions & 2 deletions samples/ocp/1.6.1/storage_csm_powermax_v2110.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "debug"
- name: "CSI_LOG_LEVEL"
value: "debug"
value: "info"
# CSI driver log format
# Allowed values: "TEXT" or "JSON"
# Default value: "TEXT"
Expand Down Expand Up @@ -221,7 +221,7 @@ spec:
# 'pmax' represents a string prepended to each volume created by the CSI driver
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner@sha256:405a14e1aa702f7ea133cea459e8395fe40a6125c088c55569e696d48e1bd385
args: ["--volume-name-prefix=pmax"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher@sha256:b4d611100ece2f9bc980d1cb19c2285b8868da261e3b1ee8f45448ab5512ab94
- name: registrar
Expand Down
4 changes: 2 additions & 2 deletions samples/ocp/1.6.1/storage_csm_powerscale_v2110.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "debug"
- name: "CSI_LOG_LEVEL"
value: "debug"
value: "info"
controller:
envs:
# X_CSI_ISI_QUOTA_ENABLED: Indicates whether the provisioner should attempt to set (later unset) quota
Expand Down Expand Up @@ -226,7 +226,7 @@ spec:
sideCars:
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner@sha256:405a14e1aa702f7ea133cea459e8395fe40a6125c088c55569e696d48e1bd385
args: ["--volume-name-prefix=csipscale"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher@sha256:b4d611100ece2f9bc980d1cb19c2285b8868da261e3b1ee8f45448ab5512ab94
- name: registrar
Expand Down
2 changes: 1 addition & 1 deletion samples/ocp/1.6.1/storage_csm_powerstore_v2111.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
- name: KUBELET_CONFIG_DIR
value: /var/lib/kubelet
- name: CSI_LOG_LEVEL
value: debug
value: info
sideCars:
# 'csivol' represents a string prepended to each volume created by the CSI driver
- name: provisioner
Expand Down
2 changes: 1 addition & 1 deletion samples/ocp/1.6.1/storage_csm_unity_v2111.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
# Allowed values: "error", "warn"/"warning", "info", "debug"
# Default value: "info"
- name: CSI_LOG_LEVEL
value: debug
value: info
# CSI driver log format
# Allowed values: "TEXT" or "JSON"
# Default value: "TEXT"
Expand Down
2 changes: 1 addition & 1 deletion samples/ocp/1.7.0/storage_csm_powerflex_v2120.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
# 'k8s' represents a string prepended to each volume created by the CSI driver
- name: provisioner
image: registry.k8s.io/sig-storage/csi-provisioner@sha256:672e45d6a55678abc1d102de665b5cbd63848e75dc7896f238c8eaaf3c7d322f
args: ["--volume-name-prefix=k8s"]
args: ["--volume-name-prefix=csivol"]
- name: attacher
image: registry.k8s.io/sig-storage/csi-attacher@sha256:6e54dae32284f60a2de1645c527715e4c934e5ce7899560c0d845bac957118dc
- name: registrar
Expand Down
Loading

0 comments on commit 0ce34ae

Please sign in to comment.