Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comment to authSecret field in manifest #186

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

meggm
Copy link
Contributor

@meggm meggm commented Mar 14, 2023

Description

Added the required comments for the authSecret field in the manifest file.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#583

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Deployed the PowerStore driver via CSM-operator after the comment has been added.

@meggm meggm merged commit 8c6e3c2 into main Mar 14, 2023
@meggm meggm deleted the authSecret_comment branch March 14, 2023 16:21
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* Added comment to authSecret field in manifest

* Added comment to authSecret field in manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants