Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for secrets getting regenerated on apply of driver manifest #271

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

rensyct
Copy link
Contributor

@rensyct rensyct commented Jun 6, 2023

Description

This PR has fix for secrets getting regenerated on kubectl apply of any driver manifest.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#743

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  1. Installed the operator followed by install of Unity driver.
  2. Make change to any of the field in driver manifest and apply the changes
  3. Check the secrets. It should not get generated.
    Repeat step 2 couple of times and ensure that secrets are not getting regenerated.

@rensyct rensyct merged commit d149e66 into main Jun 6, 2023
@rensyct rensyct deleted the fix-for-secrets-getting-regenerated branch July 17, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants