Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step fails as Karavictl returns YAML instead of JSON #276

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

donatwork
Copy link
Contributor

Description

Scenario "Install PowerScale Driver(With Authorization)" consistently failed with err: failed to unmarshal token apiVersion: v1. Issue discovered with latest version of karavictl built from main. Karavictl is now returning YAML which breaks the JSON unmarshalling.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#853

Checklist:

  • [X ] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • [X ] Install PowerScale Driver(With Authorization) passes. Code is used in common step to setup token.

@donatwork donatwork merged commit b5d480e into main Jun 15, 2023
@donatwork donatwork deleted the bugfix-853-karavictl-yaml branch June 15, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants