Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI-PowerStore: Adding support for feature volume limits #286

Merged
merged 8 commits into from
Jul 18, 2023
Merged

CSI-PowerStore: Adding support for feature volume limits #286

merged 8 commits into from
Jul 18, 2023

Conversation

suryagupta4
Copy link
Contributor

Description

  • Changes for adding support of volume limits feature.
  • Added PowerStore v2.8.0 config.
  • Added Resiliency v1.7.0 config.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#878
dell/csm#885

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran make unit-test
  • Verified the feature after installing the driver via csm-operator. Further volume creation is not happening as per the value set to the parameter X_CSI_POWERSTORE_MAX_VOLUMES_PER_NODE as expected by the feature.

@suryagupta4 suryagupta4 self-assigned this Jul 5, 2023
rensyct
rensyct suggested changes Jul 10, 2023
View reviewed changes
operatorconfig/driverconfig/powerstore/v2.8.0/controller.yaml Outdated
@@ -0,0 +1,270 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove files and folder related to 2.5.0

tests/config/driverconfig/badDriver/v2.8.0/bad.yaml Outdated
@@ -0,0 +1,4 @@
this snfoiasga
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove files and folder related to 2.5.0

tests/config/driverconfig/powerstore/v2.8.0/bad.yaml Outdated
@@ -0,0 +1,19 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove files and folder related to 2.7.0

@suryagupta4 suryagupta4 merged commit 0d43f04 into main Jul 18, 2023
@suryagupta4 suryagupta4 deleted the feature/volume-limits branch April 26, 2024 06:13
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
CSI-PowerStore: Adding support for feature volume limits (#286)
b688602 
* Powerstore 2.8 support and changes for volume limits feature

* updating driver version in test file

* removed older config files and driver sample

* UT fix

* updated driver version in powerstore config sample yaml

* updated namespace variable for configmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alankar-verma alankar-verma alankar-verma approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@rensyct rensyct rensyct approved these changes

@sakshi-garg1 sakshi-garg1 Awaiting requested review from sakshi-garg1

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees

@suryagupta4 suryagupta4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryagupta4 @rensyct @adarsh-dell @alankar-verma