Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated common config file as part of SCT feature #324

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

rajendraindukuri
Copy link
Collaborator

@rajendraindukuri rajendraindukuri commented Aug 18, 2023

Description

  • Updated common config file
  • Excluded rule G101 to avoid false positive "Potential Hardcoded credentials"

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#876

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Tested using local csm operator runs and the results look good

When storageCapacity flag is set to false:

image

image

When storageCapacity flag is set to true:

image

image

image

@rajendraindukuri
Copy link
Collaborator Author

Gosec issue we are seeing here is a false positive and needs a human intervention to see if it is an actual issue. I checked the same and does not seem to be a potential security threat. So I am planning to exclude that particular issue.
PFB link for more details:
securego/gosec#295

@rajendraindukuri rajendraindukuri merged commit d043934 into main Aug 21, 2023
7 of 8 checks passed
@shanmydell shanmydell deleted the feature-876-storage-capacity-tracking-updates branch June 11, 2024 10:31
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* Updated missing common config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants