Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSI-PowerFlex v2.9 support to csm-operator #378

Merged
merged 16 commits into from
Oct 30, 2023
Merged

Add CSI-PowerFlex v2.9 support to csm-operator #378

merged 16 commits into from
Oct 30, 2023

Conversation

VamsiSiddu-7
Copy link
Contributor

Description

Added CSI-Powerflex v2.9.0 support and removed v2.6.0 config.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1012

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the csi-powerflex driver using csm-operator and the installation is successful
  • Ran cert-csi with supported protocols the cert-csi passed with 100%

jooseppi-luna
jooseppi-luna requested changes Oct 23, 2023
View reviewed changes
tests/config/driverconfig/powerflex/v2.9.0/controller.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we copy the v2.9.0 changes into this file? Same comment for the other files in this folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/shared/common.go
@@ -27,10 +27,10 @@ import (

// ConfigVersions used for all unit tests
const (
PFlexConfigVersion string = "v2.8.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only change the PFlex version, I think changing the others is causing the unit tests to fail. ConfigVersion, UpgradeConfigVersion, and JumpUpgradeConfigVersion are used by PScale tests, not PFlex tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change these also ConfigVersion, UpgradeConfigVersion, and JumpUpgradeConfigVersion. I verfied powerflex unit tests also depend on the above variables. The unit tests are passing now

@jooseppi-luna
Copy link
Contributor

Also, would you be able to run pflex e2e tests against this change? I can help with that if needed

@VamsiSiddu-7
Copy link
Contributor Author

@jooseppi-luna I have ran e2e test for csi-powerflex driver. I am attaching the screenshot here.
3

@VamsiSiddu-7
Copy link
Contributor Author

@jooseppi-luna I have addressed your review comments. Please review it again thanks.

@jooseppi-luna jooseppi-luna self-requested a review October 27, 2023 13:25
jooseppi-luna
jooseppi-luna previously approved these changes Oct 27, 2023
View reviewed changes
chimanjain
chimanjain approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@chimanjain chimanjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VamsiSiddu-7 VamsiSiddu-7 merged commit a0961ea into main Oct 30, 2023
7 of 8 checks passed
@shanmydell shanmydell deleted the powerflex-v2.9-changes branch June 11, 2024 10:32
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Add CSI-PowerFlex v2.9 support to csm-operator (#378)
44e3db1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@chimanjain chimanjain chimanjain approved these changes

@jooseppi-luna jooseppi-luna jooseppi-luna left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VamsiSiddu-7 @jooseppi-luna @chimanjain @nitesh3108 @suryagupta4