Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test go.mod issues caused by dependabot updates #384

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

jooseppi-luna
Copy link
Contributor

Description

Dependabot updated some of our otel imports in e2e tests, but this left the go.mod broken, generating the following error when we ran go mod tidy:

go: github.com/dell/csm-operator/tests/e2e/steps imports
        k8s.io/kubernetes/test/e2e/framework/kubectl imports
        k8s.io/kubernetes/test/utils imports
        k8s.io/apiserver/pkg/admission/plugin/webhook/mutating imports
        k8s.io/component-base/tracing imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
        go.opentelemetry.io/otel/exporters/otlp/internal: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/dell/csm-operator/tests/e2e/steps imports
        k8s.io/kubernetes/test/e2e/framework/kubectl imports
        k8s.io/kubernetes/test/utils imports
        k8s.io/apiserver/pkg/admission/plugin/webhook/mutating imports
        k8s.io/component-base/tracing imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
        go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

Based on this issue in the opentelemetry-go GitHub repo, I bumped up some of the dependencies in the go.mod and fixed the issue.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1012

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Successfully ran powerflex, powerscale, and powerstore e2e tests

@jooseppi-luna jooseppi-luna merged commit 3a5e9e8 into main Nov 13, 2023
7 of 8 checks passed
@donatwork donatwork deleted the fix-e2e-go-mod branch March 2, 2024 23:13
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
Co-authored-by: Don Khan <don.khan@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants