-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth proxy status fix #465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming checks will pass
// TODO: Currently commented this block of code as the API used to get the latest deployment status is not working as expected | ||
// TODO: Can be uncommented once this issues gets sorted out | ||
controllerReplicas, controllerStatus, controllerErr := getDeploymentStatus(ctx, instance, r) | ||
if controllerErr != nil { | ||
log.Infof("error from getDeploymentStatus: %s", controllerErr.Error()) | ||
} | ||
|
||
// Auth proxy has no daemonset. Putting this if/else in here and setting nodeStatusGood to true by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we capturing this improvement, leave a comment in code is not a good practice but then also easy to lose sight of issues. Similarly there is TODO above as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharathsreekanth thanks for bringing that up, once v1.4.2 is out I will scope out the refactoring work and work on getting that into backlog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO block above is from 6+ months ago but hopefully we will be able to address that as well
for _, deployment := range deploymentList.Items { | ||
deployment := deployment | ||
switch deployment.Name { | ||
case "authorization-ingress-nginx-controller": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this check pass if the namespace isn't authorization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching that.
That will be a known issue for 1.9.2 and fixed in 1.10
* Add permissions for SC removal. (#431) * Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Change namespace name to match documentation. (#437) * go-yaml version update (#438) * go-yaml version update * update go-yaml package to latest * remove extra verbs * remove duplicate verbs and add correct test files for resiliency UT --------- Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * reverting #426 changes (#444) * Update final manifests for posting of Operator 1.4.1 (#445) * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue * Final manifest update and apex client (#447) * Add csm watch permissions. (#448) * Merged CSM Module Status * Fix App-Mob node error (#457) Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> * Bump up CSM Operator version to 1.4.2 (#458) * update csm operator version to 1.4.2 * bump-up-op-version-1.4.2 * updated version in operator.yaml * adding missing arg to fix e2e * update authorization e2e (#459) * skip cert validation in e2e (#460) * Fixing FSGroupPolicy issue (#463) * Fixing FSGroupPolicy issue * Add unit test --------- Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> * Fix for controller race, daemon status, and obs namespace (#464) * test controller state calc * add debug logs * check for driver * add daemonnset update * adds ns fix for when pod ns dis not csm ns * add ns check for daemon and deployment as well * fix typo * fix typo * explicitly return nil * add missing replace statements --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * Auth proxy status fix (#465) * actions * working on auth proxy status check * finished status check * fix 1 * fix or * code compiles * keep auth proxy out of daemonset check * trying to figure out deployment name * formatting * fix auth name in if condition * no daemonset * fix * added log statements * added another log statement * fix log statement * logs logs logs * compile * more logs * add logs and try updating status from handlesuccess * remove UpdateStatus call for now * adding csm label to auth * remove extraneous string replacement * removing commented code * Update actions.yml * fix merge issue * fix fmt * fix pscale + obs issue (#467) * fix some issues * fiix label issue, add debug logs * add more debug * more debugg lines * fix pscale issue * remmove debug logs * gofmt * set available to 0 en deployment is not checked * fix if check --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * update final manifests (#468) * fix vetting issues (#477) Co-authored-by: grosnj1 <J.Grosner@emc.com> --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com>
* Verified merge fixed release v1.4.2 (#479) * Add permissions for SC removal. (#431) * Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Change namespace name to match documentation. (#437) * go-yaml version update (#438) * go-yaml version update * update go-yaml package to latest * remove extra verbs * remove duplicate verbs and add correct test files for resiliency UT --------- Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * reverting #426 changes (#444) * Update final manifests for posting of Operator 1.4.1 (#445) * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue * Final manifest update and apex client (#447) * Add csm watch permissions. (#448) * Merged CSM Module Status * Fix App-Mob node error (#457) Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> * Bump up CSM Operator version to 1.4.2 (#458) * update csm operator version to 1.4.2 * bump-up-op-version-1.4.2 * updated version in operator.yaml * adding missing arg to fix e2e * update authorization e2e (#459) * skip cert validation in e2e (#460) * Fixing FSGroupPolicy issue (#463) * Fixing FSGroupPolicy issue * Add unit test --------- Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> * Fix for controller race, daemon status, and obs namespace (#464) * test controller state calc * add debug logs * check for driver * add daemonnset update * adds ns fix for when pod ns dis not csm ns * add ns check for daemon and deployment as well * fix typo * fix typo * explicitly return nil * add missing replace statements --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * Auth proxy status fix (#465) * actions * working on auth proxy status check * finished status check * fix 1 * fix or * code compiles * keep auth proxy out of daemonset check * trying to figure out deployment name * formatting * fix auth name in if condition * no daemonset * fix * added log statements * added another log statement * fix log statement * logs logs logs * compile * more logs * add logs and try updating status from handlesuccess * remove UpdateStatus call for now * adding csm label to auth * remove extraneous string replacement * removing commented code * Update actions.yml * fix merge issue * fix fmt * fix pscale + obs issue (#467) * fix some issues * fiix label issue, add debug logs * add more debug * more debugg lines * fix pscale issue * remmove debug logs * gofmt * set available to 0 en deployment is not checked * fix if check --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * update final manifests (#468) * fix vetting issues (#477) Co-authored-by: grosnj1 <J.Grosner@emc.com> --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * PR feedback --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com>
* Test branch (#482) * Verified merge fixed release v1.4.2 (#479) * Add permissions for SC removal. (#431) * Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Change namespace name to match documentation. (#437) * go-yaml version update (#438) * go-yaml version update * update go-yaml package to latest * remove extra verbs * remove duplicate verbs and add correct test files for resiliency UT --------- Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * reverting #426 changes (#444) * Update final manifests for posting of Operator 1.4.1 (#445) * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue * Final manifest update and apex client (#447) * Add csm watch permissions. (#448) * Merged CSM Module Status * Fix App-Mob node error (#457) Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> * Bump up CSM Operator version to 1.4.2 (#458) * update csm operator version to 1.4.2 * bump-up-op-version-1.4.2 * updated version in operator.yaml * adding missing arg to fix e2e * update authorization e2e (#459) * skip cert validation in e2e (#460) * Fixing FSGroupPolicy issue (#463) * Fixing FSGroupPolicy issue * Add unit test --------- Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> * Fix for controller race, daemon status, and obs namespace (#464) * test controller state calc * add debug logs * check for driver * add daemonnset update * adds ns fix for when pod ns dis not csm ns * add ns check for daemon and deployment as well * fix typo * fix typo * explicitly return nil * add missing replace statements --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * Auth proxy status fix (#465) * actions * working on auth proxy status check * finished status check * fix 1 * fix or * code compiles * keep auth proxy out of daemonset check * trying to figure out deployment name * formatting * fix auth name in if condition * no daemonset * fix * added log statements * added another log statement * fix log statement * logs logs logs * compile * more logs * add logs and try updating status from handlesuccess * remove UpdateStatus call for now * adding csm label to auth * remove extraneous string replacement * removing commented code * Update actions.yml * fix merge issue * fix fmt * fix pscale + obs issue (#467) * fix some issues * fiix label issue, add debug logs * add more debug * more debugg lines * fix pscale issue * remmove debug logs * gofmt * set available to 0 en deployment is not checked * fix if check --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * update final manifests (#468) * fix vetting issues (#477) Co-authored-by: grosnj1 <J.Grosner@emc.com> --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * PR feedback --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * add KUBE_NODE_NAME back in * add KUBE_NODE_NAME back in * add KUBE_NODE_NAME back into tests * Update dell-csm-operator.clusterserviceversion.yaml --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com>
* Test branch (#482) * Verified merge fixed release v1.4.2 (#479) * Add permissions for SC removal. (#431) * Bump_up_csm-operator_version_to_1.4.1 (#434) * Patch version support (#433) * Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity * Updating module config version for Pmax, Pscale, PFlex and unity * Update storage_csm_powerflex.yaml * version changed to 2.9.1 * version changed to 2.9.1 * Enabling github actions for all branch * updated version to 2.9.1 for unity, powerflex, powerscale and powermax * Adding the support of PStore v2.9.1 * Adding the support of PFlex v2.9.1 * Version bumpup replication 1.7.1 * Bump up version for authorization, resiliency * update csi-metadata-retriever version to 1.6.1 * update reverseproxy version to 2.8.1 --------- Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> * Change namespace name to match documentation. (#437) * go-yaml version update (#438) * go-yaml version update * update go-yaml package to latest * remove extra verbs * remove duplicate verbs and add correct test files for resiliency UT --------- Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> * [bug-1120]: Update Authorization sidecar to use insecure flag (#442) * fix auth cert * remove constant * remove duplicate verbs * reverting #426 changes (#444) * Update final manifests for posting of Operator 1.4.1 (#445) * KRV-20573/csm status (#446) * add module status * Adding CSM Module status * Addressing the comments for PR * Making code reusable * Fix formatting issue * Resolving gosec issue * Final manifest update and apex client (#447) * Add csm watch permissions. (#448) * Merged CSM Module Status * Fix App-Mob node error (#457) Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> * Bump up CSM Operator version to 1.4.2 (#458) * update csm operator version to 1.4.2 * bump-up-op-version-1.4.2 * updated version in operator.yaml * adding missing arg to fix e2e * update authorization e2e (#459) * skip cert validation in e2e (#460) * Fixing FSGroupPolicy issue (#463) * Fixing FSGroupPolicy issue * Add unit test --------- Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> * Fix for controller race, daemon status, and obs namespace (#464) * test controller state calc * add debug logs * check for driver * add daemonnset update * adds ns fix for when pod ns dis not csm ns * add ns check for daemon and deployment as well * fix typo * fix typo * explicitly return nil * add missing replace statements --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * Auth proxy status fix (#465) * actions * working on auth proxy status check * finished status check * fix 1 * fix or * code compiles * keep auth proxy out of daemonset check * trying to figure out deployment name * formatting * fix auth name in if condition * no daemonset * fix * added log statements * added another log statement * fix log statement * logs logs logs * compile * more logs * add logs and try updating status from handlesuccess * remove UpdateStatus call for now * adding csm label to auth * remove extraneous string replacement * removing commented code * Update actions.yml * fix merge issue * fix fmt * fix pscale + obs issue (#467) * fix some issues * fiix label issue, add debug logs * add more debug * more debugg lines * fix pscale issue * remmove debug logs * gofmt * set available to 0 en deployment is not checked * fix if check --------- Co-authored-by: grosnj1 <J.Grosner@emc.com> * update final manifests (#468) * fix vetting issues (#477) Co-authored-by: grosnj1 <J.Grosner@emc.com> --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * PR feedback --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com> * add KUBE_NODE_NAME back in * add KUBE_NODE_NAME back in * add KUBE_NODE_NAME back into tests * Update dell-csm-operator.clusterserviceversion.yaml --------- Co-authored-by: Don Khan <don.khan@dell.com> Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com> Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com> Co-authored-by: HarishH-DELL <harish.h2@dell.com> Co-authored-by: panigs7 <spandita.panigrahi@dell.com> Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com> Co-authored-by: Aaron Tye <tyeaaron@gmail.com> Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com> Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com> Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com> Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: abhi16394 <abhi.muralidhara@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: grosnj1 <J.Grosner@emc.com>
Description
Currently, the authorization proxy server status is always failed in csm-operator. This is for a couple reasons:
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Ran auth proxy e2e test. Will run full e2e tests before fixed-release-v1.4.2 is released.