Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick v1.4.3 changes into operator main branch #515

Merged
merged 11 commits into from
Mar 5, 2024

Conversation

jooseppi-luna
Copy link
Contributor

@jooseppi-luna jooseppi-luna commented Mar 3, 2024

Description

Cherry-picking csm-operator v1.4.3 changes into main for v1.5.0 release. Also deleting unnecessary certificate sample files for observability (this was done in v1.4.3, but as part of a commit making v1.4.3 version updates, so it could not be cherry-picked over).

GitHub Issues

GitHub Issue #
dell/csm#1091

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

I am going to run csm-operator e2e tests on this branch on Monday, please review PR but do not merge -- I will merge once tests pass. Unit tests pass with no degradation of coverage.

jooseppi-luna and others added 6 commits March 2, 2024 12:17
* fix standalone AM status

* add debug logs

* Revert "add debug logs"

This reverts commit 0ecb8ba.

* add debug logs back

This reverts commit e7eaa71.

* try requeue when csm.state is failed

* fix panic error

* move sync error def

* add UpdateStatus call to reconcile

* remove extra debug logs

---------

Co-authored-by: JacobGros <jacobgrosner4@gmail.com>
* add custom region support

* add file for unit test

* remove minio hardcode from vsl

* fix unit tests for 1.9.3

* clean up import
* add AM v1.0.2

* update version for testing
* final manifest update

* indentation fix
mbasha-dell
mbasha-dell previously approved these changes Mar 4, 2024
JacobGros
JacobGros previously approved these changes Mar 4, 2024
Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

JacobGros
JacobGros previously approved these changes Mar 4, 2024
Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

mbasha-dell
mbasha-dell previously approved these changes Mar 4, 2024
@JacobGros JacobGros dismissed stale reviews from mbasha-dell and themself via 8987fa4 March 4, 2024 22:24
JacobGros
JacobGros previously approved these changes Mar 4, 2024
Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-adding my approval

JacobGros
JacobGros previously approved these changes Mar 4, 2024
Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-adding my approval (again 😄 )

Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-adding my approval (for a third time 😃 )

@jooseppi-luna jooseppi-luna merged commit 0067f14 into main Mar 5, 2024
8 checks passed
@shanmydell shanmydell deleted the cherry-pick-1.4.3 branch June 11, 2024 10:33
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* Fix intermittent app-mobility status error (#504)

* fix standalone AM status

* add debug logs

* Revert "add debug logs"

This reverts commit 0ecb8ba.

* add debug logs back

This reverts commit e7eaa71.

* try requeue when csm.state is failed

* fix panic error

* move sync error def

* add UpdateStatus call to reconcile

* remove extra debug logs

---------

Co-authored-by: JacobGros <jacobgrosner4@gmail.com>

* Remove "minio" as the region for the Velero resources (#505)

* add custom region support

* add file for unit test

* remove minio hardcode from vsl

* fix unit tests for 1.9.3

* clean up import

* Add AM 1.0.2 support (#509)

* add AM v1.0.2

* update version for testing

* Update version-values.yaml (#511)

* Final manifest update (#514)

* final manifest update

* indentation fix

* remove unneeded certificate files

* fix golangci-lint issues

* update version for unit tests

* Update version-values.yaml

---------

Co-authored-by: JacobGros <jacobgrosner4@gmail.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants