Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go mod in the test folder #791

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Update go mod in the test folder #791

merged 1 commit into from
Nov 20, 2024

Conversation

meggm
Copy link
Contributor

@meggm meggm commented Nov 20, 2024

Description

Updated the go mod in the test folder for running the operator in dev mode.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1601

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested the installation of PowerScale Driver in the k8s cluster using make install and make run
    Screenshot 2024-11-20 163857
    Screenshot 2024-11-20 163910

Attaching the e2e test screenshot and the detailed result is attached in the defect.
image

Signed-off-by: meghana_gm <meghana.gm@dell.com>
Copy link
Contributor

@mgandharva mgandharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@harishp8889 harishp8889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meggm did you built the image and tested with that?

@meggm
Copy link
Contributor Author

meggm commented Nov 20, 2024

@meggm did you built the image and tested with that?

Attaching the e2e results with the built image

@meggm meggm merged commit 5e4d7a3 into main Nov 20, 2024
7 checks passed
@meggm meggm deleted the go-mod-updates branch November 20, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants