Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed redeclared filepath #825

Merged
merged 2 commits into from
Dec 16, 2024
Merged

removed redeclared filepath #825

merged 2 commits into from
Dec 16, 2024

Conversation

gilltaran
Copy link
Contributor

@gilltaran gilltaran commented Dec 16, 2024

Description

Filepath imported 2 times causing E2E compilation issue.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1642

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

This compilation issue was coming before
[root@e2e]# ./run-e2e-test.sh --unity --cert-csi=/root/cert-csi/cert-csi --dellctl=/root/dellctl --karavictl=/root/karavictl
go: downloading golang.org/x/sys v0.28.0
go: downloading golang.org/x/term v0.27.0
go: downloading golang.org/x/text v0.21.0
go: downloading golang.org/x/sync v0.10.0
go: downloading golang.org/x/crypto v0.31.0
/root/taran/csm-operator/tests/e2e
Failed to compile e2e:

github.com/dell/csm-operator/tests/e2e/steps

steps/steps_def.go:30:2: filepath redeclared in this block
steps/steps_def.go:28:2: other declaration of filepath
steps/steps_def.go:30:2: "path/filepath" imported and not used

Ginkgo ran 1 suite in 1m10.775356939s

Test Suite Failed

After fixing
Executed E2E after that compilation issue is not coming

[root@ e2e]# ./run-e2e-test.sh --unity --cert-csi=/root/cert-csi/cert-csi --dellctl=/root/dellctl --karavictl=/root/karavictl
/root/taran/csm-operator/tests/e2e
  W1213 07:53:44.747935  538516 test_context.go:538] Unable to find in-cluster config, using default host : https://127.0.0.1:6443
  I1213 07:53:44.748014 538516 test_context.go:561] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite: CSM Operator End-to-End Tests - /root/taran/csm-operator/tests/e2e

=================================================================================
Random Seed: 1734094408

Will run 1 of 1 specs

[BeforeSuite]
/root/taran/csm-operator/tests/e2e/e2e_test.go:98
STEP: Getting test environment variables @ 12/13/24 07:53:44.753
STEP: [unity] @ 12/13/24 07:53:44.753
STEP: Reading values file @ 12/13/24 07:53:44.753
STEP: Getting a k8s client @ 12/13/24 07:53:44.756
[BeforeSuite] PASSED [0.008 seconds]

@gilltaran gilltaran merged commit 620927e into main Dec 16, 2024
7 checks passed
@gilltaran gilltaran deleted the bugfix-E2E-compilation-techops branch December 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants