Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSM image version update from nightly to latest version #860

Merged
merged 7 commits into from
Jan 16, 2025
Merged

CSM image version update from nightly to latest version #860

merged 7 commits into from
Jan 16, 2025

Conversation

mgandharva
Copy link
Contributor

@mgandharva mgandharva commented Jan 15, 2025 •
edited by JacobGros
Loading

Description

Image versions are updated from nightly to the latest version in the operatorconfig

Note:

This PR has to be merged once all the images are released.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran sanity to check minimal samples are pulling the correct version

JacobGros
JacobGros reviewed Jan 15, 2025
View reviewed changes
operatorconfig/driverconfig/powerflex/v2.13.0/node.yaml Outdated
@@ -91,7 +91,7 @@ spec:
allowPrivilegeEscalation: true
capabilities:
add: ["SYS_ADMIN"]
image: quay.io/dell/container-storage-modules/csi-vxflexos:nightly
image: quay.io/dell/container-storage-modules/csi-vxflexos:v2.13.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should image pull policy be changed to IfNotPresent in operatorconfig?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@anandrajak1 anandrajak1 marked this pull request as ready for review January 15, 2025 16:39
anandrajak1
anandrajak1 previously requested changes Jan 15, 2025
View reviewed changes
operatorconfig/driverconfig/powerflex/v2.13.0/controller.yaml Outdated
@@ -217,7 +217,7 @@ spec:
- name: socket-dir
mountPath: /var/run/csi
- name: driver
image: quay.io/dell/container-storage-modules/csi-vxflexos:nightly
image: quay.io/dell/container-storage-modules/csi-vxflexos:v2.13.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

operatorconfig/driverconfig/powerflex/v2.13.0/node.yaml Outdated
@@ -197,7 +197,7 @@ spec:
mountPath: /host_opt_emc_path
initContainers:
- name: mdm-container
image: quay.io/dell/container-storage-modules/csi-vxflexos:nightly
image: quay.io/dell/container-storage-modules/csi-vxflexos:v2.13.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

operatorconfig/driverconfig/powermax/v2.13.0/controller.yaml Outdated
@@ -236,7 +236,7 @@ spec:
- name: socket-dir
mountPath: /var/run/csi
- name: driver
image: quay.io/dell/container-storage-modules/csi-powermax:nightly
image: quay.io/dell/container-storage-modules/csi-powermax:v2.13.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

operatorconfig/driverconfig/powermax/v2.13.0/node.yaml Outdated
@@ -90,7 +90,7 @@ spec:
capabilities:
add: ["SYS_ADMIN"]
allowPrivilegeEscalation: true
image: quay.io/dell/container-storage-modules/csi-powermax:nightly
image: quay.io/dell/container-storage-modules/csi-powermax:v2.13.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

operatorconfig/driverconfig/powerscale/v2.13.0/controller.yaml Outdated
@@ -239,7 +239,7 @@ spec:
- name: socket-dir
mountPath: /var/run/csi
- name: csi-metadata-retriever
image: quay.io/dell/container-storage-modules/csi-metadata-retriever:nightly
image: quay.io/dell/container-storage-modules/csi-metadata-retriever:v2.13.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

operatorconfig/moduleconfig/authorization/v2.1.0/container.yaml Show resolved Hide resolved
operatorconfig/moduleconfig/csireverseproxy/v2.12.0/container.yaml Outdated
@@ -1,5 +1,5 @@
name: reverseproxy
image: quay.io/dell/container-storage-modules/csipowermax-reverseproxy:nightly
image: quay.io/dell/container-storage-modules/csipowermax-reverseproxy:v2.12.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

operatorconfig/moduleconfig/replication/v1.11.0/container.yaml Outdated
@@ -1,5 +1,5 @@
name: dell-csi-replicator
image: quay.io/dell/container-storage-modules/dell-csi-replicator:nightly
image: quay.io/dell/container-storage-modules/dell-csi-replicator:v1.11.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

operatorconfig/moduleconfig/replication/v1.11.0/controller.yaml Outdated
@@ -272,7 +272,7 @@ spec:
value: /app/certs
- name: X_CSI_REPLICATION_CONFIG_FILE_NAME
value: config
image: quay.io/dell/container-storage-modules/dell-replication-controller:nightly
image: quay.io/dell/container-storage-modules/dell-replication-controller:v1.11.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

operatorconfig/driverconfig/powerscale/v2.13.0/node.yaml Outdated
@@ -80,7 +80,7 @@ spec:
capabilities:
add: ["SYS_ADMIN"]
allowPrivilegeEscalation: true
image: quay.io/dell/container-storage-modules/csi-isilon:nightly
image: quay.io/dell/container-storage-modules/csi-isilon:v2.13.0
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to IfNotPresent

JacobGros
JacobGros reviewed Jan 15, 2025
View reviewed changes
operatorconfig/driverconfig/powerscale/v2.13.0/controller.yaml Outdated
@@ -239,7 +239,7 @@ spec:
- name: socket-dir
mountPath: /var/run/csi
- name: csi-metadata-retriever
image: quay.io/dell/container-storage-modules/csi-metadata-retriever:nightly
image: quay.io/dell/container-storage-modules/csi-metadata-retriever:v2.13.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image does not exist, 1.10.0 is latest
https://quay.io/repository/dell/container-storage-modules/csi-metadata-retriever?tab=tags&tag=latest

alikdell
alikdell previously approved these changes Jan 15, 2025
View reviewed changes
@JacobGros
Update sdc image to Quay, fix metadata image, change pull policy (#865)
7e3e44d 
* switch repo from docker to quay for sdc

* fix metadata image and change pull policy
alikdell
alikdell previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@alikdell alikdell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from 1.13

ChristianAtDell
ChristianAtDell reviewed Jan 16, 2025
View reviewed changes
pkg/modules/testdata/cr_powerstore_resiliency.yaml
configVersion: "v1.11.0"
configVersion: "v1.12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Resiliency module a version behind the main release? I noticed that it's at v1.12.0 while most everything else is bumping to 1.13.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, looks like 1.12 is the latest; added here: https://quay.io/repository/dell/container-storage-modules/podmon?tab=tags

@alikdell
Copy link
Contributor

Approving for 1.13 release

sharmilarama
sharmilarama approved these changes Jan 16, 2025
View reviewed changes
Copy link

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving to release 1.13

@alikdell alikdell merged commit 85d0e5c into main Jan 16, 2025
7 checks passed
@alikdell alikdell deleted the mg/image-version-update branch January 16, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@ChristianAtDell ChristianAtDell ChristianAtDell approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@alikdell alikdell alikdell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mgandharva @alikdell @JacobGros @sharmilarama @anandrajak1 @ChristianAtDell @santhoshatdell