Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP E2E fixes for Ephemeral Unity and Powerstore #861

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

kumarp20
Copy link
Contributor

@kumarp20 kumarp20 commented Jan 15, 2025

Description

This PR aims to address a testing configuration that prevented ephemeral volume tests from running in PowerStore and Unity installations.
This also fixes the operator e2e compile issue introduced by #850 .

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1678

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

E2E test script has been tested with arguments "--pstore --no-modules" and "--unity --no-modules" to verify the related test scenarios run and pass.

@kumarp20 kumarp20 changed the title Jacobgros/fix e2e compile OCP E2E fixes for Ephemeral Unity and Powerstore Jan 15, 2025
bpjain2004
bpjain2004 previously approved these changes Jan 15, 2025
prablr79
prablr79 previously approved these changes Jan 15, 2025
Copy link

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

panigs7
panigs7 previously approved these changes Jan 15, 2025
@ChristianAtDell ChristianAtDell mentioned this pull request Jan 15, 2025
9 tasks
JacobGros
JacobGros previously approved these changes Jan 15, 2025
Copy link

@AronAtDell AronAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for CSM 1.13.

@JacobGros JacobGros merged commit 795339b into main Jan 15, 2025
7 checks passed
@JacobGros JacobGros deleted the jacobgros/fix-e2e-compile branch January 15, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants