-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP E2E fixes for Ephemeral Unity and Powerstore #861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarp20
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
gilltaran,
harishp8889,
HarishH-DELL,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
meggm,
mgandharva,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
shaynafinocchiaro and
atye
as code owners
January 15, 2025 08:11
kumarp20
changed the title
Jacobgros/fix e2e compile
OCP E2E fixes for Ephemeral Unity and Powerstore
Jan 15, 2025
bpjain2004
previously approved these changes
Jan 15, 2025
prablr79
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
panigs7
previously approved these changes
Jan 15, 2025
9 tasks
JacobGros
previously approved these changes
Jan 15, 2025
ChristianAtDell
dismissed stale reviews from JacobGros, panigs7, prablr79, and bpjain2004
via
January 15, 2025 21:50
2bf3104
alikdell
approved these changes
Jan 15, 2025
JacobGros
approved these changes
Jan 15, 2025
anandrajak1
approved these changes
Jan 15, 2025
AronAtDell
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for CSM 1.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to address a testing configuration that prevented ephemeral volume tests from running in PowerStore and Unity installations.
This also fixes the operator e2e compile issue introduced by #850 .
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
E2E test script has been tested with arguments "--pstore --no-modules" and "--unity --no-modules" to verify the related test scenarios run and pass.