Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount Drivers Params and Add ReverseProxy Port #876

Merged

Conversation

falfaroc
Copy link
Contributor

@falfaroc falfaroc commented Jan 27, 2025

Description

Dynamically mount the drivers params when Mount Credentials is being used. Also, dynamically adds the reverse proxy port to the Driver Params in the mount credentials approach.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1614

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ensured that the reverse proxy port is dynamically added to the drivers config params.
$ k describe cm -n powermax powermax-config-params
Name:         powermax-config-params
Namespace:    powermax
Labels:       <none>
Annotations:  <none>

Data
====
driver-config-params.yaml:
----

CSI_LOG_LEVEL: debug
CSI_LOG_FORMAT: TEXT
CSI_POWERMAX_REVERSE_PROXY_PORT: 2222


BinaryData
====

Events:  <none>
  • Add unit tests to ensure dynamic addition of params.
  • Mount powermax-config-params on the reverse proxy
   reverseproxy:
...
      X_CSI_REVPROXY_SECRET_FILEPATH:   /etc/powermax/config
      X_CSI_REVPROXY_USE_SECRET:        true
      X_CSI_POWERMAX_CONFIG_PATH:       /powermax-config-params/driver-config-params.yaml (HERE)
    Mounts:
      /app/certs from cert-dir (rw)
      /app/tls from tls-secret (rw)
      /etc/powermax from powermax-reverseproxy-secret (rw)
      powermax-config-params from powermax-config-params (rw) (HERE)

Also, dynamically adds the reverse proxy port to the config params
@falfaroc falfaroc force-pushed the usr/falfaroc/mount-config-reverse-proxy branch from 94b80f1 to f3dbf35 Compare January 27, 2025 20:40
@falfaroc falfaroc changed the title Usr/falfaroc/mount config reverse proxy Mount Drivers Params and Add ReverseProxy Port Jan 28, 2025
@falfaroc falfaroc merged commit 532f8c2 into usr/spark/mount-credentials Jan 29, 2025
6 of 7 checks passed
@falfaroc falfaroc deleted the usr/falfaroc/mount-config-reverse-proxy branch January 29, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants