Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common base image #116

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Use common base image #116

merged 1 commit into from
Nov 9, 2023

Conversation

tdawe
Copy link
Contributor

@tdawe tdawe commented Nov 9, 2023

Description

Use common base image

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1031

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built all images with common base image

@tdawe tdawe merged commit 7a8c970 into main Nov 9, 2023
8 checks passed
@tdawe tdawe deleted the use-common-base-image branch November 9, 2023 17:06
santhoshatdell
santhoshatdell reviewed Nov 9, 2023
View reviewed changes
image.mk
sidecar-migrator-dev:
$(CONTAINER_TOOL) build . -t ${SIDECAR_IMAGE_M_TAG} -f Dockerfiles/Dockerfile.dev --target migrator --build-arg BASEIMAGE=$(BASEIMAGE)
sidecar-node-rescanner-dev: download-csm-common
$(CONTAINER_TOOL) build . -t ${SIDECAR_IMAGE_NR_TAG} -f Dockerfiles/Dockerfile.dev --target node-rescanner --build-arg BASEIMAGE=$(DEFAULT_BASEIMAGE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(eval include csm-common.mk) is missing for sidecar-node-rescanner-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshatdell santhoshatdell santhoshatdell left review comments

@rodrigobassil rodrigobassil rodrigobassil approved these changes

@AronAtDell AronAtDell AronAtDell approved these changes

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@delldubey delldubey Awaiting requested review from delldubey

@gallacher gallacher Awaiting requested review from gallacher

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@hoppea2 hoppea2 Awaiting requested review from hoppea2

@nidtara nidtara Awaiting requested review from nidtara

@shanmydell shanmydell Awaiting requested review from shanmydell

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdawe @AronAtDell @santhoshatdell @rodrigobassil