Skip replication enabled SC with PowerStore Metro mode in replicator sidecar #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyakonduri
previously requested changes
Aug 30, 2024
Comment on lines
+42
to
+51
| // Check for PowerMax SRDF Metro and skip since it is only supported at the driver level | ||
| if value, ok := class.Parameters["replication.storage.dell.com/RdfMode"]; ok && strings.ToUpper(value) == "METRO" { | ||
| log.V(common.InfoLevel).Info("Metro replication is not supported by Dell CSI Replication Controllers") | ||
| return false | ||
| } | ||
|
|
||
| // Check for PowerStore Metro and skip since it is only supported at the driver level | ||
| if value, ok := class.Parameters["replication.storage.dell.com/mode"]; ok && strings.ToUpper(value) == "METRO" { | ||
| log.V(common.InfoLevel).Info("Metro replication is not supported by Dell CSI Replication Controllers") | ||
| return false |
There was a problem hiding this comment.
Suggested change
| // Check for PowerMax SRDF Metro and skip since it is only supported at the driver level | |
| if value, ok := class.Parameters["replication.storage.dell.com/RdfMode"]; ok && strings.ToUpper(value) == "METRO" { | |
| log.V(common.InfoLevel).Info("Metro replication is not supported by Dell CSI Replication Controllers") | |
| return false | |
| } | |
| // Check for PowerStore Metro and skip since it is only supported at the driver level | |
| if value, ok := class.Parameters["replication.storage.dell.com/mode"]; ok && strings.ToUpper(value) == "METRO" { | |
| log.V(common.InfoLevel).Info("Metro replication is not supported by Dell CSI Replication Controllers") | |
| return false | |
| // Check for Metro and skip since it is only supported at the driver level | |
| if value, ok := class.Parameters["replication.storage.dell.com/RdfMode"]; (ok && strings.ToUpper(value) == "METRO") || | |
| (value, ok = class.Parameters["replication.storage.dell.com/mode"]; ok && strings.ToUpper(value) == "METRO") { | |
| log.V(common.InfoLevel).Info("Metro replication is not supported by Dell CSI Replication Controllers") | |
| return false | |
| } | |
santhoshatdell
dismissed
satyakonduri’s stale review
I don't see much performance improvement with this. BTW, did the suggested change work?
santhoshatdell
requested review from
AronAtDell,
bharathsreekanth,
ChristianAtDell,
donatwork,
delldubey,
gallacher,
harshaatdell,
hoppea2,
nidtara,
shanmydell and
mbasha-dell
as code owners
donatwork
approved these changes
Sep 3, 2024
Comment on lines
+42
to
+51
| // Check for PowerMax SRDF Metro and skip since it is only supported at the driver level | ||
| if value, ok := class.Parameters["replication.storage.dell.com/RdfMode"]; ok && strings.ToUpper(value) == "METRO" { | ||
| log.V(common.InfoLevel).Info("Metro replication is not supported by Dell CSI Replication Controllers") | ||
| return false | ||
| } | ||
|
|
||
| // Check for PowerStore Metro and skip since it is only supported at the driver level | ||
| if value, ok := class.Parameters["replication.storage.dell.com/mode"]; ok && strings.ToUpper(value) == "METRO" { | ||
| log.V(common.InfoLevel).Info("Metro replication is not supported by Dell CSI Replication Controllers") | ||
| return false |
There was a problem hiding this comment.
We seem to be relying on assuming a minimum version of Replication for the driver. What could go wrong if they changed to use an older Replication version. What about pods changing during an upgrade/downgrade? Is there any danger of DU/DL?
There was a problem hiding this comment.
Driver and replicator side car runs in the same pod. Old pod with older versions will be servicing the request till the new one comes fully up and running. I don't think there will be any issue here.
It is recommended to use published versions for all drivers/modules in a CSM release. I cannot recollect the document location though.
| @@ -62,7 +62,7 @@ func (m *mockIdentity) GetMigrationCapabilities(_ context.Context) (MigrationCap | |||
|
|
|||
| func getSupportedActions() (ReplicationCapabilitySet, []*replication.SupportedActions) { | |||
| capResponse := &replication.GetReplicationCapabilityResponse{} | |||
| for i := 0; i < 3; i++ { | |||
| for i := int32(0); i < 3; i++ { | |||
There was a problem hiding this comment.
Was this flagged by the new linter? Seems to break a popular idiom.
There was a problem hiding this comment.
Yes, it was complained recently.
harshaatdell
approved these changes
Sep 3, 2024
lukeatdell
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip replication enabled StorageClass with PowerStore Metro mode in replicator sidecar.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Unit test coverage for dell-csi-replicator increased from 80.1% to 80.5%
Changes are minimal. Changes follow same as PowerMax Metro. Unit test covered it.