Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing test dirs to unit-test target #169

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

lukeatdell
Copy link
Contributor

@lukeatdell lukeatdell commented Nov 5, 2024

Description

GitHub actions was only running unit test for the controller directory and repctl.
This commit creates new makefile targets for the directories with relevant code for which unit tests should be run.

Note: the make test target would have been used, but it also attempts to run the golang tests for e2e in the ./test directory.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have maintained backward compatibility

How Has This Been Tested?

Used the Makefile target make unit-test to execute the unit tests.
image

@lukeatdell lukeatdell merged commit 9b28bc9 into main Nov 5, 2024
8 checks passed
@lukeatdell lukeatdell deleted the usr/lukeatdell/add-missing-unit-tests branch November 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants