Bugfix/deploy service account #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falfaroc
requested review from
AronAtDell,
bharathsreekanth,
ChristianAtDell,
donatwork,
delldubey,
gallacher,
harshaatdell,
hoppea2,
santhoshatdell,
nidtara and
shanmydell
as code owners
falfaroc
force-pushed
the
bugfix/deploy-service-account
branch
from
95ffbd1 to
df5f332
Compare
santhoshatdell
previously approved these changes
Jan 4, 2023
harshaatdell
approved these changes
Jan 5, 2023
harshaatdell
suggested changes
Jan 9, 2023
There was a problem hiding this comment.
@falfaroc -- dell/csm#463 is marked as fixed for CSM 1.5 release and is present as part of the ChangeLog. Please create another defect to indicate the remaining problem and tag the PR against that.
|
@harshaatdell Created the defect and updated the issue accordingly here. |
falfaroc
force-pushed
the
bugfix/deploy-service-account
branch
from
fecdce8 to
eac56ec
Compare
santhoshatdell
previously approved these changes
Jan 10, 2023
santhoshatdell
approved these changes
Jan 10, 2023
harshaatdell
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update from #62. There are two ways for installing
csm-replication. This covers the all-in-one usingrepctlfor installing instead of the installation script.GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
csm-replicationusingrepctl. Ensured that the correct service account and secret are created and that replication is running correctly.