Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Comment out duplicate entries in the sample secret.yaml file #1030

Closed
dtonnesen opened this issue Nov 3, 2023 · 5 comments
Closed
Assignees
Labels
area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@dtonnesen
Copy link

dtonnesen commented Nov 3, 2023

The sample secret.yaml file is below. As as user I find it very confusing to include this extra stanza at the bottom:

nasName: "nas-server"

  • username: "admin"
    password: "Password123"
    systemID: "2b11bb111111bb1b"
    endpoint: "https://127.0.0.2"
    skipCertificateValidation: true
    mdm: "10.0.0.3,10.0.0.4"

The problem is that all these entries are already present, and uncommented, in the top of the file. If you do not notice that, your CSI install will fail because it adds a non-existent PowerFlex setup. I suggest commenting all entries at the top, which explain what each variable is, and just leaving the bottom stanza. In addition, a comment can be added that if you have multiple systems you can add another stanza.

Username for accessing PowerFlex system.

If authorization is enabled, username will be ignored.

  • username: "admin"

    Password for accessing PowerFlex system.

    If authorization is enabled, password will be ignored.

    password: "password"

    System name/ID of PowerFlex system.

    systemID: "1a99aa999999aa9a"

    Previous names used in secret of PowerFlex system.

    allSystemNames: "pflex-1,pflex-2"

    REST API gateway HTTPS endpoint for PowerFlex system.

    If authorization is enabled, endpoint should be the HTTPS localhost endpoint that

    the authorization sidecar will listen on

    endpoint: "https://127.0.0.1"

    Determines if the driver is going to validate certs while connecting to PowerFlex REST API interface.

    Allowed values: true or false

    Default value: true

    skipCertificateValidation: true

    indicates if this array is the default array

    needed for backwards compatibility

    only one array is allowed to have this set to true

    Default value: false

    isDefault: true

    defines the MDM(s) that SDC should register with on start.

    Allowed values: a list of IP addresses or hostnames separated by comma.

    Default value: none

    mdm: "10.0.0.1,10.0.0.2"

    NFS is only supported on PowerFlex storage system 4.0.x

    nasName: name of NAS server used for NFS volumes

    nasName value must be specified in secret for performing NFS (file) operations.

    Allowed Values: string

    Default Value: "none"

    nasName: "nas-server"
  • username: "admin"
    password: "Password123"
    systemID: "2b11bb111111bb1b"
    endpoint: "https://127.0.0.2"
    skipCertificateValidation: true
    mdm: "10.0.0.3,10.0.0.4"
@dtonnesen dtonnesen added needs-triage Issue requires triage. type/feature-request New feature request. This is the default label associated with a feature request issue. labels Nov 3, 2023
@csmbot
Copy link
Collaborator

csmbot commented Nov 3, 2023

@dtonnesen: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and respond appropriately.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

@adarsh-dell adarsh-dell added the area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex label Nov 6, 2023
@sharmilarama sharmilarama added type/bug Something isn't working. This is the default label associated with a bug issue. and removed type/feature-request New feature request. This is the default label associated with a feature request issue. labels Nov 7, 2023
@sharmilarama sharmilarama changed the title [FEATURE]:Comment out duplicate entries in the sample secret.yaml file [BUG]:Comment out duplicate entries in the sample secret.yaml file Nov 7, 2023
@coulof coulof self-assigned this Nov 7, 2023
@sharmilarama sharmilarama added this to the v1.9.0 milestone Nov 7, 2023
@sharmilarama sharmilarama removed the needs-triage Issue requires triage. label Nov 7, 2023
@sharmilarama
Copy link
Collaborator

/sync

@hoppea2
Copy link
Collaborator

hoppea2 commented Nov 7, 2023

/sync

@csmbot
Copy link
Collaborator

csmbot commented Nov 7, 2023

link: 18930

@coulof
Copy link
Collaborator

coulof commented Nov 10, 2023

Thanks for your feedback @dtonnesen, you will see the changes in the next release

@coulof coulof closed this as completed Nov 10, 2023
@adarsh-dell adarsh-dell changed the title [BUG]:Comment out duplicate entries in the sample secret.yaml file [BUG]: Comment out duplicate entries in the sample secret.yaml file Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

6 participants