Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out the sample to avoid error when not needed #175

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Comment out the sample to avoid error when not needed #175

merged 2 commits into from
Nov 10, 2023

Conversation

coulof
Copy link
Collaborator

@coulof coulof commented Nov 7, 2023

Description

Commenting out the 2nd array per requirement here : dell/csm#1030

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1030

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Not tested

@coulof coulof merged commit 432367d into main Nov 10, 2023
3 of 4 checks passed
@coulof coulof deleted the update-sample-config branch September 24, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panigs7 panigs7 panigs7 approved these changes

@gallacher gallacher gallacher approved these changes

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coulof @gallacher @panigs7