adding v2.6 support for powermax #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyamurthy
requested review from
abhi16394,
bpjain2004,
Deepak-Ghivari,
francis-nijay,
karthikk92,
bandak2,
mjsdell,
nitesh3108,
prablr79,
rajendraindukuri,
rensyct and
panigs7
as code owners
boyamurthy
force-pushed
the
powermax-2.6-support
branch
from
7fd3c89 to
4974391
Compare
delldubey
previously approved these changes
Feb 7, 2023
rensyct
reviewed
Feb 8, 2023
| @@ -99,8 +134,6 @@ spec: | |||
| # Allowed values: map of key-value pairs | |||
| # Default value: None | |||
| nodeSelector: | |||
| # Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint | |||
There was a problem hiding this comment.
@boyamurthy, we can keep the examples for master in K8s 1.23 samples as they are supported
There was a problem hiding this comment.
updated node selector .
samples/powermax_v260_ops_410.yaml
Outdated
| @@ -82,8 +117,6 @@ spec: | |||
| # Allowed values: map of key-value pairs | |||
| # Default value: None | |||
| nodeSelector: | |||
| # Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint | |||
There was a problem hiding this comment.
Examples for master under nodeSelector and taints can be kept in 4.10 samples as OCP 4.10 uses K8s 1.23
There was a problem hiding this comment.
updated node selector .
boyamurthy
force-pushed
the
powermax-2.6-support
branch
from
ab7520a to
2f72363
Compare
boyamurthy
force-pushed
the
powermax-2.6-support
branch
from
5628aca to
187b0a4
Compare
rensyct
approved these changes
Feb 13, 2023
rajendraindukuri
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
unit test
installation
sanity test
