Setting default value of X_CSI_POWERSTORE_ENABLE_CHAP to false for CSI-Powerstore #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alankar-verma
requested review from
sakshi-garg1,
AkshaySainiDell,
suryagupta4,
adarsh-dell and
rishabhatdell
alankar-verma
requested review from
abhi16394,
bpjain2004,
boyamurthy,
chimanjain,
Deepak-Ghivari,
francis-nijay,
karthikk92,
bandak2,
mjsdell,
nitesh3108,
prablr79,
rajendraindukuri,
rensyct and
panigs7
as code owners
suryagupta4
changed the title
suryagupta4
approved these changes
May 24, 2023
adarsh-dell
approved these changes
May 24, 2023
rensyct
reviewed
May 25, 2023
There was a problem hiding this comment.
@alankar-verma , do we want to change the default value for previous versions (2.5 and 2.6) of the driver?
|
yes @rensyct , this should have been taken care for previous versions as well. |
|
Please sign your commit. |
alankar-verma
force-pushed
the
powerstore_disable_CHAP
branch
from
5107f69 to
821da4a
Compare
Signed-off-by: alankar-verma <Alankar.Verma@dell.com>
alankar-verma
force-pushed
the
powerstore_disable_CHAP
branch
from
821da4a to
8f7d0ad
Compare
Done |
rensyct
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for disabling CHAP by default for csi-powerstore
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Installed the driver with the changes. Checked the value of X_CSI_POWERSTORE_ENABLE_CHAP in node pods. Ran cert-csi for iSCSI protocol