Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Make ome_inventory module options available via environment variables #480

Closed
zigford opened this issue Mar 1, 2023 · 3 comments
Labels
area/ome ome modules needs-triage Issue requires triage. type/feature-request New feature or request
Milestone

Comments

@zigford
Copy link
Contributor

zigford commented Mar 1, 2023

dellemc.openmanage.ome_inventory hostname, password, port parameters should be able to be set via environment variables rather than parameters to the dynamic inventory. This allows their use in a secure environment like AWX without having to store the values in plain text in the inventory file.

Alternatives:
I've read that ansible can support extra-vars to a dynamic inventory file, but that the inventory file needs to support it.

Having the values available through environment variables also allows an inventory to be configured generically, and simply running it under a different environment can connect to a different ome without needing a seperate inventory file.

@zigford zigford added needs-triage Issue requires triage. type/feature-request New feature or request labels Mar 1, 2023
@anupamaloke anupamaloke added the area/ome ome modules label Mar 1, 2023
@sachin-apa
Copy link
Collaborator

@zigford Thanks for requesting a feature enhancement.
Env variable is something we have to enhance in the plugin, do please let us know if you are interested in submitting the PR for the same?
I do see when we pass -e(extra var) argument the same gets added into all the hosts. -e "key=value"

@anupamaloke

@zigford
Copy link
Contributor Author

zigford commented Mar 1, 2023

@sachin-apa, I have a PR in the waiting, but I'm just completing unit tests before submission.
I did test the -e "key=value" method, but it seems the inventory plugin has to support it. I can look at adding that too.

@sachin-apa
Copy link
Collaborator

Merged the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ome ome modules needs-triage Issue requires triage. type/feature-request New feature or request
Projects
Development

No branches or pull requests

3 participants