Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ome_inventory module options available via environment variables #481

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Make ome_inventory module options available via environment variables #481

merged 1 commit into from
Jun 23, 2023

Conversation

zigford
Copy link
Contributor

@zigford zigford commented Mar 2, 2023

Signed-off-by: Jesse Harris zigford@gmail.com

Description

To make some module parameters available as environment variables.

GitHub Issues

#480

ISSUE TYPE

  • Feature Pull Request
COMPONENT NAME

ome_inventory

OUTPUT
$ export OME_USER=admin
$ export OME_PASSWORD=supersecretpass
$ export OME_HOST=dell-ome01.example.com

$ cat inventory.yml
---

plugin: dellemc.openmanage.ome_inventory
validate_certs: false

$ ansible-inventory -i inventory.yml --list
{
    "All Devices": {
        "children": [
            "Plugin Groups",
            "System Groups",
            "Custom Groups"
        ],
        "hosts": [
            "192.168.0.181",
         ]
    }
}

Copy link
Collaborator

@sachin-apa sachin-apa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do please update the Copywrite section to change the version from 7.2.0 to 7.4.0 @line No 5

plugins/inventory/ome_inventory.py Outdated Show resolved Hide resolved
plugins/inventory/ome_inventory.py Outdated Show resolved Hide resolved
plugins/inventory/ome_inventory.py Outdated Show resolved Hide resolved
plugins/inventory/ome_inventory.py Outdated Show resolved Hide resolved
plugins/inventory/ome_inventory.py Outdated Show resolved Hide resolved
plugins/inventory/ome_inventory.py Outdated Show resolved Hide resolved
plugins/inventory/ome_inventory.py Outdated Show resolved Hide resolved
plugins/inventory/ome_inventory.py Outdated Show resolved Hide resolved
@sachin-apa sachin-apa requested a review from anupamaloke March 2, 2023 04:48
@sachin-apa
Copy link
Collaborator

sachin-apa commented Mar 2, 2023

@zigford Thanks for the update, Let my team run through few tests and will get back if any.

Can you please mark the comments as resolved.
This is will be merged into 7.4.0 Releases (March End)

anupamaloke
anupamaloke previously approved these changes Mar 2, 2023
Copy link
Collaborator

@anupamaloke anupamaloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sachin-apa
sachin-apa previously approved these changes Apr 25, 2023
@sachin-apa sachin-apa self-requested a review April 25, 2023 07:31
@sachin-apa
Copy link
Collaborator

@zigford Can You please sign your commits.
You can just squash 3 commits into one and make sure to sign them, this is is one of the requirement for merging the PR.

Signed-off-by: Jesse Harris <zigford@gmail.com>
sachin-apa
sachin-apa previously approved these changes Apr 27, 2023
@sachin-apa sachin-apa added this to the v8.0.0 milestone Jun 23, 2023
@sachin-apa sachin-apa merged commit 6996548 into dell:collections Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants