Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: idrac_storage_volume #630

Merged

Conversation

ABHISHEK-SINHA10
Copy link
Contributor

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 commented Mar 1, 2024

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 98.10066% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 93.43%. Comparing base (77868f7) to head (bb0d019).

Files Patch % Lines
plugins/modules/idrac_storage_volume.py 96.19% 5 Missing and 13 partials ⚠️
.../unit/plugins/modules/test_idrac_storage_volume.py 99.65% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           collections     #630      +/-   ##
===============================================
+ Coverage        93.26%   93.43%   +0.17%     
===============================================
  Files              195      197       +2     
  Lines            32302    33354    +1052     
  Branches          4973     5126     +153     
===============================================
+ Hits             30125    31164    +1039     
+ Misses            1332     1331       -1     
- Partials           845      859      +14     
Flag Coverage Δ
units 93.43% <98.10%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajshekarp87 rajshekarp87 added this to the v9.1.0 milestone Mar 21, 2024
@rajshekarp87 rajshekarp87 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Mar 22, 2024
@sachin-apa sachin-apa merged commit 960009d into dell:collections Mar 22, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/completed Validation is completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: dellemc_idrac_storage_volume - No such controller found! when trying to create RAID 1 with NVMe disks
10 participants