Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Role][idrac_firmware]: Fixing failure in testcase #796

Merged
merged 15 commits into from
Feb 5, 2025
Merged

[Role][idrac_firmware]: Fixing failure in testcase #796

merged 15 commits into from
Feb 5, 2025

Conversation

Kritika-Bhateja-03
Copy link
Contributor

@Kritika-Bhateja-03 Kritika-Bhateja-03 commented Jan 28, 2025 •
edited
Loading

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

ABHISHEK-SINHA10
ABHISHEK-SINHA10 reviewed Jan 31, 2025
View reviewed changes
roles/idrac_firmware/molecule/cifs_share-10554/prepare.yml Outdated Show resolved Hide resolved
roles/idrac_firmware/molecule/ftp_share-10596/prepare.yml Outdated Show resolved Hide resolved
roles/idrac_firmware/molecule/http_share-10589/prepare.yml Outdated Show resolved Hide resolved
roles/idrac_firmware/molecule/https_share-10584/prepare.yml Outdated Show resolved Hide resolved
roles/idrac_firmware/molecule/https_share_apply_update_false-10591/prepare.yml Outdated Show resolved Hide resolved
roles/idrac_firmware/molecule/httpsproxy_share-10590/prepare.yml Outdated Show resolved Hide resolved
roles/idrac_firmware/molecule/negative_scenarios-10585/prepare.yml Outdated Show resolved Hide resolved
roles/idrac_firmware/molecule/nfs_share-10572/prepare.yml Outdated Show resolved Hide resolved
roles/idrac_firmware/molecule/resources/tests/downgrade.yml Show resolved Hide resolved
@Kritika-Bhateja-03 Kritika-Bhateja-03 force-pushed the usr/Kritika-Bhateja-03/fixing_failure_in_idrac_firmware_role branch from d930f2b to ddf5229 Compare January 31, 2025 11:25
@Kritika-Bhateja-03 Kritika-Bhateja-03 force-pushed the usr/Kritika-Bhateja-03/fixing_failure_in_idrac_firmware_role branch from ccf16e9 to 29a032c Compare February 4, 2025 12:11
trisha-dell
trisha-dell previously approved these changes Feb 4, 2025
View reviewed changes
ShivamSh3
ShivamSh3 previously approved these changes Feb 4, 2025
View reviewed changes
@Kritika-Bhateja-03 Kritika-Bhateja-03 force-pushed the usr/Kritika-Bhateja-03/fixing_failure_in_idrac_firmware_role branch from 6dac271 to 9f237b2 Compare February 4, 2025 20:06
trisha-dell
trisha-dell previously approved these changes Feb 5, 2025
View reviewed changes
ShivamSh3
ShivamSh3 previously approved these changes Feb 5, 2025
View reviewed changes
@Kritika-Bhateja-03 Kritika-Bhateja-03 force-pushed the usr/Kritika-Bhateja-03/fixing_failure_in_idrac_firmware_role branch from 01f356b to 3124aef Compare February 5, 2025 06:22
@Kritika-Bhateja-03 Kritika-Bhateja-03 added the validation/completed Validation is completed label Feb 5, 2025
@rajshekarp87 rajshekarp87 merged commit 6237490 into collections Feb 5, 2025
41 checks passed
@rajshekarp87 rajshekarp87 deleted the usr/Kritika-Bhateja-03/fixing_failure_in_idrac_firmware_role branch February 5, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajshekarp87 rajshekarp87 rajshekarp87 approved these changes

@sachin-apa sachin-apa sachin-apa approved these changes

@ShivamSh3 ShivamSh3 ShivamSh3 approved these changes

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 Awaiting requested review from ABHISHEK-SINHA10 ABHISHEK-SINHA10 is a code owner

@trisha-dell trisha-dell Awaiting requested review from trisha-dell

Assignees

@Kritika-Bhateja-03 Kritika-Bhateja-03

Labels
validation/completed Validation is completed
Projects
OpenManage Ansible Collection
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kritika-Bhateja-03 @ansible-collections-svc @rajshekarp87 @sachin-apa @trisha-dell @ABHISHEK-SINHA10 @ShivamSh3