Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX dkms built issues for rhel kernel update ,change prerm script to … #20

Merged
merged 2 commits into from
Mar 13, 2017
Merged

Conversation

GoPerry
Copy link
Contributor

@GoPerry GoPerry commented Mar 11, 2017

When user update kernel image to new version ,prerm script will remove all the dkms modules from old kernel tree. replace dkms remove with dkms uninstall ,after change ,dkms modules will be built and installed for new kernel image .
The Patch has been verifyed and test the updating issue .

[root@localhost 7.3.2]# uname -a
Linux localhost.localdomain 3.10.0-514.el7.x86_64 #1 SMP Wed Oct 19 11:24:13 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux

#rpm -Uvvh kernel-3.10.0-514.6.1.el7.x86_64.rpm

[root@localhost dkms]# dkms status
snd-hda-codec-realtek, 1.3: added
[root@localhost dkms]# dkms status
snd-hda-codec-realtek, 1.3, 3.10.0-514.6.1.el7.x86_64, x86_64: installed (original_module exists)

@superm1
Copy link
Contributor

superm1 commented Mar 13, 2017

I mentioned this to Perry previously, but want to mention it publicly too.
This fixes this issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=621846, which was caused by the patch included in Debian here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586724 (and upstreamed here 65be6b9)

That open Debian bug should be closable after this @yuzaipiaofei merges this pull request.

@GoPerry GoPerry merged commit 974d838 into dell:master Mar 13, 2017
evelikov pushed a commit to evelikov/dkms that referenced this pull request Jan 20, 2020
Add an action "unbuild" to align with the existing "build" one.

This provides for a complete symmetry - add/remove, build/unbuild and
install/uninstall.

Apart from the seeming cosmetic affect, this function is required when
the binary kernel module(s) produced with "dkms build" must be pruned.

Without this command that is not possible since using:
 - "dkms uninstall" will remove the symlinks/copies produced with
"dkms install", while
 - "dkms remove" will erase all references of the dkms module. Hence
"dkms status" will have no references about the module.

This allows for a proper fix for dell#20
while avoiding regressions like dell#77

Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
superm1 pushed a commit that referenced this pull request Feb 19, 2020
Add an action "unbuild" to align with the existing "build" one.

This provides for a complete symmetry - add/remove, build/unbuild and
install/uninstall.

Apart from the seeming cosmetic affect, this function is required when
the binary kernel module(s) produced with "dkms build" must be pruned.

Without this command that is not possible since using:
 - "dkms uninstall" will remove the symlinks/copies produced with
"dkms install", while
 - "dkms remove" will erase all references of the dkms module. Hence
"dkms status" will have no references about the module.

This allows for a proper fix for #20
while avoiding regressions like #77

Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants