Support variable expansion in framework files #265
Conversation
|
Do you mind splitting this in 3 patches as per the 1 - 2 - 3 points above. Thanks o/ |
OK. The commit has been split into smaller ones. New test cases are also split into individual commits |
| esac | ||
| if [[ ! -f "${sign_file}" ]]; then | ||
| sign_file="/lib/modules/$kernelver/build/scripts/sign-file" |
There was a problem hiding this comment.
Just a general note: my gut feeling is that we should remove all distribution logic out of dkms, in the long run.
|
@scaronni we might want to have a special note about Fix framework file hijacking in the release notes. it might break some people's workflow, but my gut feeling is that we should not revert it but gauge what they |
|
@evelikov, sure no problem. Feel also free to make new releases when you see fit. I'm in favor of many small releases without waiting for fixes for too long. |
The resolution to issue dell#265 limited the number of variables that dkms would accept from framework.conf. It is useful to be able to configure a system wide limit of the number of parallel tasks by dkms, and so this commit adds parallel_jobs to the permitted list.
The resolution to issue #265 limited the number of variables that dkms would accept from framework.conf. It is useful to be able to configure a system wide limit of the number of parallel tasks by dkms, and so this commit adds parallel_jobs to the permitted list.
safe_sourceto avoid abuse of the framework files