fix add_module rpm_safe_upgrade handling #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes add_module() write out the rpm_safe_upgrade lock _before_ checking to see if this module-version has already been added when --rpm_safe_upgrade is specified. Before, if there was a module-version match, no rpm_safe_upgrade lock file would get written, and the old package's %preun script's `dkms remove` call would proceed when it should have stopped.
|
Created PR for proper testing of this: #25 |
|
Shall we merge this? |
I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes add_module() write out the rpm_safe_upgrade lock
before checking to see if this module-version has already been added
when --rpm_safe_upgrade is specified.
Before, if there was a module-version match, no rpm_safe_upgrade lock
file would get written, and the old package's %preun script's
dkms removecall would proceed when it should have stopped.