Revert "Fix to run under BusyBox shell" #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5da2138. Looks like m-emelchenkov wanted to fix the missing rmdir option ignore-fail-on-non-empty (issue dell#43) but that commit made it even worse: 1. errors about deleting non-empty directories (issue dell#57) 2. the directories contents get deleted by "rm -rf" in any case This option is now implemented so revert the commit to fix the newly introduced problems.
c0d3z3r0
force-pushed
the
for-upstream/fix_rmdir
branch
from
400e0b3 to
ba9057a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5da2138.
Looks like m-emelchenkov wanted to fix the missing rmdir option
ignore-fail-on-non-empty (issue #43) but that commit made it even worse:
This option is now implemented so revert the commit to fix the newly
introduced problems.
Fixes #57