Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds unit test scenarios for Auto SRDF Group creation #38

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Adds unit test scenarios for Auto SRDF Group creation #38

merged 1 commit into from
Jan 12, 2023

Conversation

delldubey
Copy link
Collaborator

Description

  • Adds unit test for Auto SRDF Group creation
  • Overall enhancement of code coverage to 91%

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#583

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test

@delldubey
Copy link
Collaborator Author

delldubey commented Jan 10, 2023 •
edited
Loading

538 scenarios (538 passed)
3582 steps (3582 passed)
PASS
coverage: 91.1% of statements

shanmydell
shanmydell previously approved these changes Jan 10, 2023
View reviewed changes
nidtara
nidtara previously approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@delldubey delldubey dismissed stale reviews from nidtara and shanmydell via 3c6ce00 January 12, 2023 07:30
boyamurthy
boyamurthy reviewed Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error in codeowners file
make sure @nidtara exists and has write access to the repository

@delldubey delldubey requested a review from boyamurthy January 12, 2023 08:27
@delldubey delldubey merged commit 7be6a18 into main Jan 12, 2023
@shanmydell shanmydell deleted the unitTest-AutoSRDF branch October 16, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmydell shanmydell shanmydell approved these changes

@boyamurthy boyamurthy boyamurthy approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@tssushma tssushma Awaiting requested review from tssushma

@nidtara nidtara Awaiting requested review from nidtara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delldubey @shanmydell @boyamurthy @nidtara