Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service datasource #103

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Service datasource #103

merged 2 commits into from
Feb 27, 2024

Conversation

AnikaAgiwal2711
Copy link
Collaborator

@AnikaAgiwal2711 AnikaAgiwal2711 commented Feb 26, 2024 •
edited
Loading

Description

removed additional properties struct as the data was dynamic

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

service ss

@alikdell
Copy link
Contributor

Please fix linting and format issues in PR

@AnikaAgiwal2711
Copy link
Collaborator Author

Please fix linting and format issues in PR

There is an internal ticket to fix these linting issues

adarsh-dell
adarsh-dell approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving by considering that there is a ticket to fix all linter and gosec warnings.

@AnikaAgiwal2711 AnikaAgiwal2711 merged commit 83a8183 into main Feb 27, 2024
1 of 4 checks passed
@shanmydell shanmydell deleted the service-datasource branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@shenda1 shenda1 shenda1 approved these changes

@Krunal-Thakkar Krunal-Thakkar Awaiting requested review from Krunal-Thakkar

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnikaAgiwal2711 @alikdell @shenda1 @adarsh-dell