Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the GetVersion function to handle 401 unauthorized error in Powerflex Driver #122

Merged
merged 23 commits into from
May 31, 2024
Merged

Updated the GetVersion function to handle 401 unauthorized error in Powerflex Driver #122

merged 23 commits into from
May 31, 2024

Conversation

KshitijaKakde
Copy link
Contributor

Description

Updated the GetVersion function to handle 401 unauthorized error

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1310

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • I have tested the changes by installing the powerflex driver on k8s and OCP environment

adarsh-dell
adarsh-dell reviewed May 28, 2024
View reviewed changes
api.go Outdated Show resolved Hide resolved
@KshitijaKakde
merge into main
73eee33 
Merge branch 'ocp-test' of https://github.com/dell/goscaleio into ocp-test
adarsh-dell
adarsh-dell reviewed May 28, 2024
View reviewed changes
api.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell reviewed May 28, 2024
View reviewed changes
api.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell reviewed May 28, 2024
View reviewed changes
api.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AkshaySainiDell
AkshaySainiDell requested changes May 30, 2024
View reviewed changes
api.go Outdated Show resolved Hide resolved
AkshaySainiDell
AkshaySainiDell approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KshitijaKakde KshitijaKakde merged commit d63da7e into main May 31, 2024
4 checks passed
@shanmydell shanmydell deleted the ocp-test branch October 16, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@ashleyvjoy ashleyvjoy Awaiting requested review from ashleyvjoy ashleyvjoy is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell rishabhatdell is a code owner

@sakshi-garg1 sakshi-garg1 Awaiting requested review from sakshi-garg1 sakshi-garg1 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KshitijaKakde @AkshaySainiDell @suryagupta4 @adarsh-dell