Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added first_name and last_name for SSO user #125

Merged
merged 2 commits into from
Jun 6, 2024
Merged

added first_name and last_name for SSO user #125

merged 2 commits into from
Jun 6, 2024

Conversation

shenda1
Copy link
Collaborator

@shenda1 shenda1 commented Jun 5, 2024

Description

PR is raised to add first name and last name fields while creating/modifying sso user.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1320

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Signed-off-by: Shendge <akash.shendge@dell.com>
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenda1 shenda1 merged commit 3e3d60c into main Jun 6, 2024
4 checks passed
@shanmydell shanmydell deleted the 4.6_sso_user branch October 16, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants