Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get compliance reports for a deployment #127

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Get compliance reports for a deployment #127

merged 1 commit into from
Jul 8, 2024

Conversation

nikitajoshi1
Copy link
Collaborator

@nikitajoshi1 nikitajoshi1 commented Jul 3, 2024 •
edited by AkshaySainiDell
Loading

Description

Get compliance report for a Deployment and related tests.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Test Result:
gerall
withFilter

AkshaySainiDell
AkshaySainiDell requested changes Jul 5, 2024
View reviewed changes
service.go Outdated Show resolved Hide resolved
service.go Outdated Show resolved Hide resolved
types/v1/serviceTypes.go Outdated Show resolved Hide resolved
@AkshaySainiDell
Copy link
Contributor

Please add the github issue link in PR description.

@nikitajoshi1 nikitajoshi1 force-pushed the DeploymentComplianceReport branch 2 times, most recently from b55e169 to 0cbb10c Compare July 5, 2024 16:40
@nikitajoshi1
Copy link
Collaborator Author

Please add the github issue link in PR description.

@AkshaySainiDell Created a github issue and added here.

AkshaySainiDell
AkshaySainiDell approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitajoshi1 nikitajoshi1 merged commit b1cdc01 into main Jul 8, 2024
4 checks passed
@gallacher gallacher deleted the DeploymentComplianceReport branch July 8, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriac11 doriac11 doriac11 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@Krunal-Thakkar Krunal-Thakkar Awaiting requested review from Krunal-Thakkar

@AnikaAgiwal2711 AnikaAgiwal2711 Awaiting requested review from AnikaAgiwal2711

@shenda1 shenda1 Awaiting requested review from shenda1

@shekhar-j shekhar-j Awaiting requested review from shekhar-j

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikitajoshi1 @AkshaySainiDell @doriac11