Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS Repository APIs #129

Merged
merged 1 commit into from
Jul 31, 2024
Merged

OS Repository APIs #129

merged 1 commit into from
Jul 31, 2024

Conversation

nikitajoshi1
Copy link
Collaborator

@nikitajoshi1 nikitajoshi1 commented Jul 25, 2024 •
edited
Loading

Description

OS Repository APIs

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
CreateDel
IDFail
GetFail
GetOSREPO
coverage

@nikitajoshi1 nikitajoshi1 force-pushed the OS-Repo-Apis branch 2 times, most recently from cb2808b to a75bc31 Compare July 25, 2024 23:36
adarsh-dell
adarsh-dell reviewed Jul 26, 2024
View reviewed changes
os_repository.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell reviewed Jul 26, 2024
View reviewed changes
os_repository.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell reviewed Jul 26, 2024
View reviewed changes
os_repository.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell reviewed Jul 26, 2024
View reviewed changes
os_repository.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell reviewed Jul 26, 2024
View reviewed changes
os_repository.go Outdated Show resolved Hide resolved
adarsh-dell
adarsh-dell reviewed Jul 26, 2024
View reviewed changes
types/v1/types.go Outdated Show resolved Hide resolved
@adarsh-dell
Copy link
Contributor

@nikitajoshi1 Can you please attach the test coverage report.

adarsh-dell
adarsh-dell requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my review comments and see if we can address them.

@nikitajoshi1
Copy link
Collaborator Author

Please check my review comments and see if we can address them.

@adarsh-dell updated and responded to comments.

@nikitajoshi1
Copy link
Collaborator Author

@nikitajoshi1 Can you please attach the test coverage report.

Coverage:
coverage

adarsh-dell
adarsh-dell approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nikitajoshi1 for considering the feedbacks.

@nikitajoshi1 nikitajoshi1 merged commit fc34c46 into main Jul 31, 2024
4 checks passed
@doriac11 doriac11 deleted the OS-Repo-Apis branch July 31, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriac11 doriac11 doriac11 approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@ashleyvjoy ashleyvjoy Awaiting requested review from ashleyvjoy ashleyvjoy is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@KshitijaKakde KshitijaKakde Awaiting requested review from KshitijaKakde KshitijaKakde is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell rishabhatdell is a code owner

@sakshi-garg1 sakshi-garg1 Awaiting requested review from sakshi-garg1 sakshi-garg1 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikitajoshi1 @adarsh-dell @doriac11