Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVMe host name could be null #140

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

baoy1
Copy link
Contributor

@baoy1 baoy1 commented Oct 22, 2024

Description

When creating an NVMe host without specifying a name, the PowerFlex manager uses HostType:ID as the display name, and we follow the same behavior.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • AT

image
image
image

@baoy1 baoy1 force-pushed the usr/baoy1/nvme_host_nullable_name branch from aa54d0d to 23031b1 Compare October 23, 2024 07:58
@baoy1 baoy1 force-pushed the usr/baoy1/nvme_host_nullable_name branch from 23031b1 to c49dc1d Compare October 24, 2024 05:43
@baoy1 baoy1 merged commit 756f3e4 into main Oct 25, 2024
4 checks passed
@baoy1 baoy1 deleted the usr/baoy1/nvme_host_nullable_name branch October 25, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants