Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding faultset support in sds and getting node/nodepool details #94

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Adding faultset support in sds and getting node/nodepool details #94

merged 5 commits into from
Jan 22, 2024

Conversation

shenda1
Copy link
Collaborator

@shenda1 shenda1 commented Jan 17, 2024 •
edited
Loading

Description

Adding faultset support in sds and getting node/nodepool details

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Tests
    image

  • Integration Tests

image

AkshaySainiDell
AkshaySainiDell requested changes Jan 18, 2024
View reviewed changes
inttests/node_test.go Outdated Show resolved Hide resolved
node.go Outdated Show resolved Hide resolved
node_test.go Outdated Show resolved Hide resolved
sds.go Outdated Show resolved Hide resolved
types/v1/nodeTypes.go Outdated Show resolved Hide resolved
AkshaySainiDell
AkshaySainiDell requested changes Jan 18, 2024
View reviewed changes
inttests/node_test.go Show resolved Hide resolved
node_test.go Outdated Show resolved Hide resolved
@AkshaySainiDell
Copy link
Contributor

@shenda1 could you please attach the code coverage ?

@shenda1
Copy link
Collaborator Author

shenda1 commented Jan 18, 2024 •
edited
Loading

@shenda1 could you please attach the code coverage ?

@AkshaySainiDell Please find below unit tests coverage

image

@shenda1 shenda1 merged commit 62fd224 into main Jan 22, 2024
1 of 4 checks passed
@shanmydell shanmydell deleted the sds_add_faultset branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnikaAgiwal2711 AnikaAgiwal2711 AnikaAgiwal2711 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@Krunal-Thakkar Krunal-Thakkar Awaiting requested review from Krunal-Thakkar

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenda1 @AkshaySainiDell @AnikaAgiwal2711